Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for Time-Of-Use Tariffs #1776

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Improvements for Time-Of-Use Tariffs #1776

merged 1 commit into from
Mar 29, 2022

Conversation

sfeilmeier
Copy link
Contributor

  • Change TimeOfUseTariff to never return null
  • Introduce TimeOfUsePrices.empty() instead
  • Adjust Controller to handle the changed logic
  • Awattar, Tibber, Corrently: throw Exception if HTTP GET result is empty
  • Update JUnit tests to reflect new Exception handling

@sfeilmeier
Improvements for Time-Of-Use Tariffs
3977acb 
- Change TimeOfUseTariff to never return null
- Introduce TimeOfUsePrices.empty() instead
- Adjust Controller to handle the changed logic
- Awattar, Tibber, Corrently: throw Exception if HTTP GET result is empty
- Update JUnit tests to reflect new Exception handling
@sfeilmeier sfeilmeier merged commit 088cd6a into develop Mar 29, 2022
@sfeilmeier sfeilmeier deleted the feature/time-of-use-improvements branch March 29, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfeilmeier