Consider inverter losses for HybridEss #1801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…may be calculated more precisely. This new calculation ensures that the ac setpoint will be more precise by considering inverter losses.
simonfey
changed the title
|
I noticed that the calculation is not reliable since the current on DC side ramps up quite quickly while the AC side may have a delay of several seconds. This calculation is a lot more reliable when I build a moving average. Consider this PR as draft. |
|
I did some further experimentation in this and did not like the solution. I managed to achieve similar results by adjusting the risk parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sfeilmeier. This PR is related to #1800
I noticed that the AC Limit calculation neglects any losses on the inverter.
This has a high impact on the actual charge rate of the battery (for me this was about 50% off).
This change will consider the losses on the inverter and provides a more precise AC limit.
In case of a calculated EssDischargePower from an unmanaged battery the losses would be 0 and not make any difference.