-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update j2mod dependency to 3.2.0 #2364
Update j2mod dependency to 3.2.0 #2364
Conversation
Bumps [com.ghgande:j2mod](https://github.com/steveohara/j2mod) from 2.5.5 to 3.2.0. - [Changelog](https://github.com/steveohara/j2mod/blob/development/RELEASE_NOTES.md) - [Commits](https://github.com/steveohara/j2mod/commits) --- updated-dependencies: - dependency-name: com.ghgande:j2mod dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
This PR will also fix the system not responding after too many Modbus/TCP requests have been made as described in this forum thread: https://www.photovoltaikforum.com/thread/205371-fems-modbus-stirbt-alle-paar-tage/ It was fixed in this PR in the j2mod repo which is part of the V2.7.0 release. Is there any way this makes it into the next openEMS/FEMS release? |
Hi, any updates on this? |
Could someone describe me what the issue was? Also, @huseyinsaht or @clehne can you please give further instructions how to reproduce this issue? In this branch I updated the dependency to the latest SNAPSHOT of J2Mod that also includes a fix when the device is disconnected (see steveohara/j2mod#144). @benutz of course we can do the merge once we verified that the issue is fixed. |
@hydroid7 See #1689, as linked above. I had already asked @da-Kai to take over this task; it's not a task for @huseyinsaht. |
Ok, #1689 in not extensive about reproduction. So if I understand correctly, steps for reproduction are:
I asked @huseyinsaht and @clehne how the issue can be reproduced. |
No, the error only shows on the actual Edge/FEMS-device, e.g. on a Beaglebone Black. I did not have the issue on my developer machine (Windows). I did not test with CM3/CM4 either. On Beaglebone Black if you start once a OpenEMS Edge with a updated j2mod version, it will "somehow reconfigure the serial device and draw it unusable". Only way to solve the problem for me was a reboot, back then when I tested this. |
@sfeilmeier @benutz @clehne |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Kai. Looks good to me. I'll merge it now. If there is any feedback coming, I'd handle it in a new PR (e.g. I do not know if it is required to provide all those configuration settings, but as there are feasible defaults, that should be ok)
Bumps com.ghgande:j2mod from 2.5.5 to 3.2.0.
Changelog
Sourced from com.ghgande:j2mod's changelog.
... (truncated)
Commits
Most Recent Ignore Conditions Applied to This Pull Request
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)