Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update j2mod dependency to 3.2.0 #2364

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 18, 2023

Bumps com.ghgande:j2mod from 2.5.5 to 3.2.0.

Changelog

Sourced from com.ghgande:j2mod's changelog.

Version 2.5.5

  • Upgraded jserialcomm to v2.5.1

Version 2.5.6

  • Added a finally block to ensure that afterMessageWrite event handler is invoked, even if the message fails to write

Version 2.5.7

  • ModbusTCPTransaction Error message is not shown in a specific case #100

Version 2.5.8

  • Upgraded jserialcomm to v2.5.3
  • ClassCastException when timeout?? #96 - made all Master facade methods thread safe
  • Code cleanup to lower Sonar score

Version 2.5.9

  • Desensitised the serial writes to allow more time to send

Version 2.6.0

  • Sanitised the setBaudRate method to make it part of the serial parameters only
  • Removed all the redundant test data for the old command test
  • Made the default SerialConnection more resilient to the connection not yet being open
  • Added retries to the serial port connection with a retry delay
  • Fixed a serious synchronisation problem with the ope/close methods in the use of SerialPort
  • Added a modpoll style command line interface to test serial connections

Version 2.6.1

  • Upgraded to jSerialComm 2.6.0

Version 2.6.2

  • Downgraded jSerialComm until [jSerialComm #277](Fazecast/jSerialComm#277) is resolved
  • Upgraded log4j to prevent security issue
  • added ModPoll class to mirror ModPoll exe capabilities
  • Created fat executable jar for testing ModPoll features
  • SHOULD NOT BE USED

Version 2.6.3

  • Fix missing logging properties in assembly
  • Fixed the release so that it isn't the fat jar that is released (2.6.2 error)
  • SHOULD NOT BE USED

Version 2.6.4

  • Fixed the release so that it isn't the fat jar that is released (2.6.3 error)
  • SHOULD NOT BE USED

Version 2.6.5

  • Upgraded to jSeralcomm 2.6.2 that contains fix for [jSerialComm #277](Fazecast/jSerialComm#277)
  • Added some code cleanups as suggested by Sonar
  • Fixed issue where slave listeners (TCP/UDP/Serial) fail silently if they cannot bind to a port
  • Bumped log4j version for testing
  • Added isConnected() method for al master facade classes #103

... (truncated)

Commits

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
com.ghgande:j2mod [>= 3.0.a, < 3.1]
com.ghgande:j2mod [>= 2.7.a, < 2.8]
com.ghgande:j2mod [>= 2.6.a, < 2.7]

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [com.ghgande:j2mod](https://github.com/steveohara/j2mod) from 2.5.5 to 3.2.0.
- [Changelog](https://github.com/steveohara/j2mod/blob/development/RELEASE_NOTES.md)
- [Commits](https://github.com/steveohara/j2mod/commits)

---
updated-dependencies:
- dependency-name: com.ghgande:j2mod
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies java Pull requests that update Java code labels Sep 18, 2023
@benutz
Copy link

benutz commented Sep 25, 2023

This PR will also fix the system not responding after too many Modbus/TCP requests have been made as described in this forum thread: https://www.photovoltaikforum.com/thread/205371-fems-modbus-stirbt-alle-paar-tage/

It was fixed in this PR in the j2mod repo which is part of the V2.7.0 release.

Is there any way this makes it into the next openEMS/FEMS release?

@sfeilmeier
Copy link
Contributor

Hi @benutz. Thanks for finding this. It's unfortunately not so easy, because we had problems with higher versions than 2.5.5 in the past - see #1689. But we'll start a new test with this information.

@benutz
Copy link

benutz commented Nov 27, 2023

Hi, any updates on this?

@sfeilmeier
Copy link
Contributor

@benutz: Unfortunately not - apart of the fact, that also @clehne experienced the same issue.

@da-Kai: You are the Linux (kernel) expert. Could you have a look into this issue?

@hydroid7
Copy link
Contributor

Could someone describe me what the issue was? Also, @huseyinsaht or @clehne can you please give further instructions how to reproduce this issue?

In this branch I updated the dependency to the latest SNAPSHOT of J2Mod that also includes a fix when the device is disconnected (see steveohara/j2mod#144).

@benutz of course we can do the merge once we verified that the issue is fixed.

@sfeilmeier
Copy link
Contributor

@hydroid7 See #1689, as linked above. I had already asked @da-Kai to take over this task; it's not a task for @huseyinsaht.

@hydroid7
Copy link
Contributor

Ok, #1689 in not extensive about reproduction.

So if I understand correctly, steps for reproduction are:

  • start the EdgeApp
  • create a "RTU Serial Modbus Bridge"
  • Console shows errors

I asked @huseyinsaht and @clehne how the issue can be reproduced.

@sfeilmeier
Copy link
Contributor

No, the error only shows on the actual Edge/FEMS-device, e.g. on a Beaglebone Black. I did not have the issue on my developer machine (Windows). I did not test with CM3/CM4 either. On Beaglebone Black if you start once a OpenEMS Edge with a updated j2mod version, it will "somehow reconfigure the serial device and draw it unusable". Only way to solve the problem for me was a reboot, back then when I tested this.

@hydroid7 hydroid7 self-assigned this Jan 18, 2024
@hydroid7 hydroid7 changed the title Bump com.ghgande:j2mod from 2.5.5 to 3.2.0 in /cnf Update j2mod dependency to 3.2.0 Jan 18, 2024
@sfeilmeier sfeilmeier assigned da-Kai and unassigned hydroid7 Jan 19, 2024
Copy link

Code Coverage

@da-Kai
Copy link
Contributor

da-Kai commented Jan 22, 2024

@sfeilmeier @benutz @clehne
I have updated this pull request to the state that I got working.
The most important changes to the default settings of j2mod were Rs485Mode=true and Rs485DelayAfterTxMicroseconds=0.
It would be nice if someone could test my changes and confirm that it works for you as well.

Copy link
Contributor

@sfeilmeier sfeilmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Kai. Looks good to me. I'll merge it now. If there is any feedback coming, I'd handle it in a new PR (e.g. I do not know if it is required to provide all those configuration settings, but as there are feasible defaults, that should be ok)

@sfeilmeier sfeilmeier merged commit af16850 into develop Jan 22, 2024
2 checks passed
@sfeilmeier sfeilmeier deleted the dependabot/maven/cnf/develop/com.ghgande-j2mod-3.2.0 branch January 22, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants