Introduce HTTP-bridge & migrate Shelly Plug S #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First test with a shelly IO plug.
added dummy BridgeHttp
|
|
moved notify
use dummy request to wait
|
|
|
|
michaelgrill
changed the title
sfeilmeier
requested changes
Dec 19, 2023
io.openems.edge.bridge.http/src/io/openems/edge/bridge/http/BridgeHttpImpl.java
Show resolved
Hide resolved
| // TODO: Execute before TOPIC_CYCLE_BEFORE_PROCESS_IMAGE, like modbus bridge | ||
| case EdgeEventConstants.TOPIC_CYCLE_BEFORE_PROCESS_IMAGE -> { | ||
|
|
||
| this.endpoints.forEach(EndpointCountdown::decreaseCycleCount); |
There was a problem hiding this comment.
Should decreaseCycleCount not only get called inside the loop? Difference would be if an Exception happens
There was a problem hiding this comment.
no the loop is only to handle endpoints wich have hit cycleCount 0 before that i decrease every cycle
io.openems.edge.bridge.http/src/io/openems/edge/bridge/http/BridgeHttpImpl.java
Outdated
Show resolved
Hide resolved
io.openems.edge.bridge.http/src/io/openems/edge/bridge/http/BridgeHttpImpl.java
Outdated
Show resolved
Hide resolved
io.openems.edge.io.shelly/src/io/openems/edge/io/shelly/shellyplug/IoShellyPlugImpl.java
Outdated
Show resolved
Hide resolved
sfeilmeier
changed the title
use offer for adding endpoint removed return and replaced with continue to fix not iterating over all elements
handle result and error in one method set every channel to null on error
|
|
sfeilmeier
approved these changes
Jan 16, 2024
|
sfeilmeier
pushed a commit
that referenced
this pull request
Feb 21, 2024
- "Fixed" bug where an exception gets throw during deactivation of a component using the HTTP-Bridge (ty @Sn0w3y #2381 (comment)) now to get an instance of a `BridgeHttp` the following code needs to be added ``` @reference private BridgeHttpFactory httpBridgeFactory; private BridgeHttp httpBridge; @activate private void activate() { this.httpBridge = this.httpBridgeFactory.get(); } @deactivate private void deactivate() { this.httpBridgeFactory.unget(this.httpBridge); this.httpBridge = null; } ``` as far as i know the exception which is happening is not intended to happen but for now to avoid unexpected behaviour because of the exception this is the prefered way to use it. - Made CycleSubscriber thread safe to avoid concurrent modification exceptions - Added time based subscribtions simple example to add a subscription with a delay of 1 minute between the calls would be ``` final var delayProvider = DelayTimeProviderChain.fixedDelay(new Delay(1L, TimeUnit.MINUTES); this.httpBridge.subscribeTime(delayProvider, "http://127.0.0.1/status", t -> { // process data }, t -> { // handle error }); ```
fanass-dev
pushed a commit
to fanass-dev/openems
that referenced
this pull request
May 6, 2024
…#2539) - "Fixed" bug where an exception gets throw during deactivation of a component using the HTTP-Bridge (ty @Sn0w3y OpenEMS#2381 (comment)) now to get an instance of a `BridgeHttp` the following code needs to be added ``` @reference private BridgeHttpFactory httpBridgeFactory; private BridgeHttp httpBridge; @activate private void activate() { this.httpBridge = this.httpBridgeFactory.get(); } @deactivate private void deactivate() { this.httpBridgeFactory.unget(this.httpBridge); this.httpBridge = null; } ``` as far as i know the exception which is happening is not intended to happen but for now to avoid unexpected behaviour because of the exception this is the prefered way to use it. - Made CycleSubscriber thread safe to avoid concurrent modification exceptions - Added time based subscribtions simple example to add a subscription with a delay of 1 minute between the calls would be ``` final var delayProvider = DelayTimeProviderChain.fixedDelay(new Delay(1L, TimeUnit.MINUTES); this.httpBridge.subscribeTime(delayProvider, "http://127.0.0.1/status", t -> { // process data }, t -> { // handle error }); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new bridge for http connections and communication.
Currently, each implementation of a device via RESTful APIs is implemented in its own bundle and is more or less stable depending on asynchronous calls.
In this PR it is currently used by the shelly IO plug as a first test.
Co-authored-by: Michael Grill [email protected]