Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved TimeLeapClock from edge.common to common #2395

Merged

Conversation

DerStoecki
Copy link
Contributor

UnitTests of Backend have no access to TimeLeapClock, this commit fixes this issue.
This will be the base for a new/refactored SumStateAlert PR in the future, that is based on #2260.

Co-authored-by: Kai Jeschek [email protected]

UnitTests of Backend have no access to TimeLeapClock, this commit fixes the issue.

Co-authored-by:  Kai Jeschek <[email protected]>
@DerStoecki DerStoecki self-assigned this Oct 23, 2023
@github-actions
Copy link

Code Coverage

Copy link
Contributor

@clehne clehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just refactoring code. Looks ok.

@clehne clehne requested a review from da-Kai October 23, 2023 15:17
@github-actions
Copy link

Code Coverage

@clehne
Copy link
Contributor

clehne commented Oct 24, 2023

@sfeilmeier It is core functionality. Better you have a quick look at it too.

@github-actions
Copy link

Code Coverage

@sfeilmeier sfeilmeier merged commit 7df7406 into OpenEMS:develop Oct 25, 2023
2 checks passed
@clehne clehne deleted the feature/MoveTimeLeapClockToCommon branch October 31, 2023 08:35
@clehne clehne restored the feature/MoveTimeLeapClockToCommon branch November 1, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants