Backend: MetadataOdoo: added AlertingSetting enum that implements Field #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't do anything yet. But will in the future, when AlertingSettings get refactored to UserAlertingSettings and OdooHandler calls different db table. This commit is one of many prepare PRs / commits for a bigger PR: SumStateAlert OpenEMS#2260 By Seperating the big OpenEMS#2260 into smaller commits we would like to make the review easier. Co-authored-by: Kai Jeschek <[email protected]>
|
|
|
As the AlertingSetting Fields are not utilizeable without and liked to OpenEMS/odoo-openems#3, they have no use in the code without the rest of OpenEMS/openems#2260. |
|
I confirm to close this PR. Is already part of the original #2260 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't do anything yet. But in the future, when AlertingSettings get refactored to UserAlertingSettings and OdooHandler calls different db table, the AlertingSetting enum will be used.
This commit is one of many prepare PRs / commits for a bigger PR: SumStateAlert #2260
By separating the big #2260 into smaller commits we would like to make the review easier.
Co-authored-by: Kai Jeschek [email protected]