UI: Install/Update Component filter to lower case #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the filter is applied to entry id/alias .toLowerCase() the filter themself should be lower case too. Co-authored-by: Ulrich Laupp <[email protected]>
|
|
clehne
approved these changes
Mar 4, 2024
fanass-dev
pushed a commit
to fanass-dev/openems
that referenced
this pull request
May 6, 2024
since the filter is applied to entry id/alias .toLowerCase() the filter themself should be lower case too. Co-authored-by: Ulrich Laupp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When entering CamelCased / Uppercase entries in the search bar of component install/update -> the components won't show/cannot be found since the filter is CaseSensitive, while the filteredComponents are not.
see :
openems/ui/src/app/edge/settings/component/update/index.component.ts
Lines 49 to 55 in 2c938aa
Fix
set filter to lowerCase
Co-authored-by: Ulrich Laupp [email protected]
Comparison
Before
After