Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add japanese language support to ui #2538

Conversation

miettal
Copy link
Contributor

@miettal miettal commented Feb 13, 2024

To be honest, it's not a perfect translation.
This translation include a lot machine translation(google-translate), however we checked one by one and fixed clearly strange japanese. So all japanese translation is not fluent japanese, but it is enough to unerstand by native japanese speakers.

We can improve japanese translation regularly, and follow upstream changes. Please consider to add japanese translation. Thank you.

To be honest, it's not a perfect translation.
This translation include a lot machine translation(google-translate),
however we checked one by one and fixed clearly strange japanese.
So all japanese translation is not fluent japanese,
but it is enough to unerstand by native japanese speakers.

We can improve japanese translation regularly, and follow upstream changes.
Please consider to add japanese translation. Thank you.

Co-authored-by: Jing Lee <[email protected]>
Co-authored-by: cvabc <[email protected]>
Co-authored-by: Hiroyuki Ikegami <[email protected]>
Copy link

Code Coverage

Copy link
Contributor

@sfeilmeier sfeilmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sfeilmeier sfeilmeier merged commit a7a3a89 into OpenEMS:develop Mar 8, 2024
2 checks passed
fanass-dev pushed a commit to fanass-dev/openems that referenced this pull request May 6, 2024
Co-authored-by: Jing Lee <[email protected]>
Co-authored-by: cvabc <[email protected]>
Co-authored-by: Hiroyuki Ikegami <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants