Bugfix: Backend: Alerting: periodic onSetSumState doesn't override SumStateSchedule #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnSetSumState gets send ~every 5min -> the oldMsg would be constantly updated and therefore would never be send. This behaviour is fixed by checking if the oldMsg/scheduled message has the same sumState (warning, fault) as the current SumState reported by the Edge.
|
|
da-Kai
approved these changes
Mar 6, 2024
sfeilmeier
approved these changes
Mar 10, 2024
fanass-dev
pushed a commit
to fanass-dev/openems
that referenced
this pull request
May 6, 2024
…e SumStateSchedule (OpenEMS#2561) OnSetSumState gets send ~every 5min -> the oldMsg would be constantly updated and therefore would never be send. This behaviour is fixed by checking if the oldMsg/scheduled message has the same sumState (warning, fault) as the current SumState reported by the Edge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
SumState not sending Emails because of onSetSumState.
Reason
Periodic OnSetSumState Event (~ every 5 min) of Edge -> refreshes scheduled Message and the "stateSince" timestamp even if the sumState is the same.
Solution
Check if the SumState changed and then update the stateSince time.
To my shame, when I reviewed the PR I only tested the Alerting mechanism with like 1-3 min delay, but when we configured an Edge with 15 min alerting we didn't receive an alerting mail (however I did when i had a delay of 3 min or so). After some debugging we found out, that the OnSetSumState Event gets triggered roughly every 5 min / periodically.