Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker Workflow #2568

Merged
merged 7 commits into from
Mar 14, 2024
Merged

Docker Workflow #2568

merged 7 commits into from
Mar 14, 2024

Conversation

da-Kai
Copy link
Contributor

@da-Kai da-Kai commented Mar 10, 2024 •
edited
Loading

Build and Release Docker images on tag events.

continuation of #2358

@da-Kai
Add a docker Workflow
96a8436 
Build and Release Docker images on tag events.
@da-Kai da-Kai requested a review from sfeilmeier March 10, 2024 14:39
@da-Kai
Copy link
Contributor Author

da-Kai commented Mar 10, 2024

@sfeilmeier is there a OpenEMS Docker Hub account?

@sfeilmeier
Copy link
Contributor

@sfeilmeier is there a OpenEMS Docker Hub account?

No, not yet. Feel free to create one.

@da-Kai
Copy link
Contributor Author

da-Kai commented Mar 10, 2024

No, not yet. Feel free to create one.

https://hub.docker.com/u/openems already exists :/

sfeilmeier
sfeilmeier requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@sfeilmeier sfeilmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I still need somebody else to do a detailed review first. Maybe Manoj?

@OpenEMS OpenEMS deleted a comment from github-actions bot Mar 12, 2024
@OpenEMS OpenEMS deleted a comment from github-actions bot Mar 12, 2024
@OpenEMS OpenEMS deleted a comment from github-actions bot Mar 12, 2024
@github-actions GitHub Actions
Copy link

Code Coverage

@manojniit
Copy link
Contributor

Looks good. I still need somebody else to do a detailed review first. Maybe Manoj?

Everything is working properly. I checked it.

@da-Kai da-Kai requested a review from sfeilmeier March 13, 2024 10:48
@github-actions GitHub Actions
Copy link

Code Coverage

sfeilmeier
sfeilmeier reviewed Mar 14, 2024
View reviewed changes
...ker/openems-edge/config.d/Controller/Api/Backend/28628d01-a978-4328-9a8f-b9c7751ed2d2.config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitpod is using these files -> https://github.com/OpenEMS/openems/blob/develop/.gitpod.yml#L17

I did not test it, but this PR would (again) break Gitpod, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right! i would have given gitpod its own folder for the time being. Just tested this configuration and its working.

The gitpod topic probably needs changes/a pull request of its own.

@github-actions GitHub Actions
Copy link

Code Coverage

sfeilmeier
sfeilmeier reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@sfeilmeier sfeilmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Special acknowledgement for the ASCII-Art 😍🚀

@sfeilmeier sfeilmeier merged commit 0a10b0b into OpenEMS:develop Mar 14, 2024
2 checks passed
@da-Kai da-Kai deleted the feature/docker-workflow branch March 18, 2024 07:02
fanass-dev pushed a commit to fanass-dev/openems that referenced this pull request May 6, 2024
@da-Kai @fanass-dev
CI: Docker Workflow (OpenEMS#2568)
63a7975 
Build and Release Docker images on tag events.
@da-Kai da-Kai mentioned this pull request May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfeilmeier sfeilmeier sfeilmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@da-Kai @sfeilmeier @manojniit