Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SunSpec: Channel values synchronized #2609

Conversation

tsicking
Copy link
Contributor

@tsicking tsicking commented Apr 4, 2024

A small fix in the mapping between SunSpec channel values and OpenEMS channel values: Previously, this was done by an onUpdate()-listener, meaning that the OpenEMS channel was one cycle behind the SunSpec channel. This is fixed here by using an onSetNextValue()-listener instead.

@tsicking tsicking requested a review from clehne April 4, 2024 08:46
Copy link

github-actions bot commented Apr 4, 2024

Code Coverage

Copy link
Contributor

@clehne clehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@clehne clehne requested a review from sfeilmeier April 5, 2024 04:14
Copy link

Code Coverage

@sfeilmeier sfeilmeier merged commit 3f42033 into OpenEMS:develop Apr 29, 2024
2 checks passed
fanass-dev pushed a commit to fanass-dev/openems that referenced this pull request May 6, 2024
* onUpdate() replaced by onSetNextValue() in mapFirstPointToChannel()
* Fix prepare-commit script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants