Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEMS Backports 2023-04 #2623

Merged
merged 28 commits into from
Apr 29, 2024
Merged

FEMS Backports 2023-04 #2623

merged 28 commits into from
Apr 29, 2024

Commits on Apr 28, 2024

  1. UI: revert calculating stepSize for charts

    - removing stepSize calculation due to chartjs breaking style in some circumstances
    - keeping max ticks limit at 6
    
    Reviewed-by: Sagar Venu <[email protected]>
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Lukas Rieger <[email protected]>
    Co-committed-by: Lukas Rieger <[email protected]>
    sfeilmeier and lukasrgr committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    d5ee8fb View commit details
    Browse the repository at this point in the history
  2. UI: remove dead link

    Removing dead link from ChpSoc (BHKW) Widget in history
    
    Reviewed-by: Sagar Venu <[email protected]>
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Lukas Rieger <[email protected]>
    Co-committed-by: Lukas Rieger <[email protected]>
    sfeilmeier and lukasrgr committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    b1a7508 View commit details
    Browse the repository at this point in the history
  3. KACO Blueplanet Gridsave BatteryInverter: state-machine improvement

    - Update Kaco Blueplanet Gridsave state-machine
    - Add grid disconnection failure state channel
    
    Reviewed-by: Michael Grill <[email protected]>
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Huseyin Sahutoglu <[email protected]>
    Co-committed-by: Huseyin Sahutoglu <[email protected]>
    sfeilmeier and huseyinsaht committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    10d2c06 View commit details
    Browse the repository at this point in the history
  4. UI: migration of ion-slides

    Migration of Ionic Slides according to [Migration Guide](https://ionicframework.com/docs/angular/slides)
    
    Reviewed-by: Sagar Venu <[email protected]>
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Lukas Rieger <[email protected]>
    Co-committed-by: Lukas Rieger <[email protected]>
    sfeilmeier and lukasrgr committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    0a98ccf View commit details
    Browse the repository at this point in the history
  5. Backend: add simulation interface

    Reviewed-by: Michael Grill <[email protected]>
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Lukas Rieger <[email protected]>
    Co-committed-by: Lukas Rieger <[email protected]>
    sfeilmeier and lukasrgr committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    4b4a83c View commit details
    Browse the repository at this point in the history
  6. UI: Fix Persistence Priority warning in channels

    Warning for persistencePriority lower than backends global priority, was also shown for equals
    
    Reviewed-by: Michael Grill <[email protected]>
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Lukas Rieger <[email protected]>
    Co-committed-by: Lukas Rieger <[email protected]>
    sfeilmeier and lukasrgr committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    65246d2 View commit details
    Browse the repository at this point in the history
  7. UI: fix esLint autofix mistake

    Reviewed-by: Sagar Venu <[email protected]>
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Lukas Rieger <[email protected]>
    Co-committed-by: Lukas Rieger <[email protected]>
    sfeilmeier and lukasrgr committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    0fe0b26 View commit details
    Browse the repository at this point in the history
  8. UI: Fix Unit in GridoptimizeChargeChart

    Co-authored-by: Stefan Feilmeier <[email protected]>
    Reviewed-by: Sagar Venu <[email protected]>
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Lukas Rieger <[email protected]>
    Co-committed-by: Lukas Rieger <[email protected]>
    3 people committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    3fdb1e6 View commit details
    Browse the repository at this point in the history
  9. UI: update to angular 16

    - Update auf Angular Version 16.
    
    **Technical description**
    
    - Replacing [kekeh/angular-mydatepicker](https://github.com/kekeh/angular-mydatepicker) with its fork [nodro7/angular-mydatepicker](https://github.com/nodro7/angular-mydatepicker)
    
    Co-authored-by: Sagar Venu <[email protected]>
    Co-authored-by: Stefan Feilmeier <[email protected]>
    Reviewed-by: Sagar Venu <[email protected]>
    Co-authored-by: Lukas Rieger <[email protected]>
    Co-committed-by: Lukas Rieger <[email protected]>
    4 people committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    3b6fdd5 View commit details
    Browse the repository at this point in the history
  10. AppCenter/Tibber: fix unset filter

    Tibber Filter could not be unset
    
    Co-authored-by: Stefan Feilmeier <[email protected]>
    Reviewed-by: Hueseyin Sahutoglu <[email protected]>
    Co-authored-by: Michael Grill <[email protected]>
    Co-committed-by: Michael Grill <[email protected]>
    3 people committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    d7115b7 View commit details
    Browse the repository at this point in the history
  11. UI: change resolution from 20 to 15 minutes

    - Optimierungen und Fehlerbehebungen am Online-Monitoring.
    
    **Technical description**
    - change the resolution to15 instead of 20
    
    Co-authored-by: Stefan Feilmeier <[email protected]>
    Reviewed-by: Lukas Rieger <[email protected]>
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Anas Shetla <[email protected]>
    Co-committed-by: Anas Shetla <[email protected]>
    3 people committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    362de1b View commit details
    Browse the repository at this point in the history
  12. UI: hide footer for history detail views

    - Hiding FooterComponent for [history Children](https://git.intranet.fenecon.de/FENECON/fems/src/commit/9d4006ba912bf7653c300321aec56b10ced2faec/ui/src/app/app-routing.module.ts#L87) due to overlapping on different heights
       > [Footercomponent overlapping content](https://forum.ionicframework.com/t/ion-footer-overlap-content/109487/6).
    
       > [Chartjs -> responsive charts](https://www.chartjs.org/docs/latest/configuration/responsive.html#important-note) approach of setting fixed height is causing the problem,
           ```onZoom``` event doesnt resize the charts canvas and chart canvas gets moved down into the footer
    
    Co-authored-by: Stefan Feilmeier <[email protected]>
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Lukas Rieger <[email protected]>
    Co-committed-by: Lukas Rieger <[email protected]>
    3 people committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    e4d4ef7 View commit details
    Browse the repository at this point in the history
  13. ModbusBridge/SunSpec: improve; fix SMA PV-Inverter getting stuck whil…

    …e parsing SunSpec
    
    **Technical description**
    
    - Remove unnecessary `throws OpenemsException` and `try...catch` in certain places (`defineModbusProtocol()`, `new ModbusProtocol()`, `addTask()`,...)
    - Optionally provide `ExecuteState` of an entire ModbusTask; this allows for more fine-grained evaluation of read errors
    - Improve parsing of SunSpec protocol; especially handle missing END_OF_MAP register in SMA (throws ILLEGAL_ADDRESS_EXCEPTION instead)
    - Switch to updated `readElementOnce` and/or improve brevity of `CompletableFuture` by using `thenCompose` instead of `thenAccept` in...
      - BatterySoltaroSingleRackVersionBImpl, BatterySoltaroSingleRackVersionCImpl, BatterySoltaroClusterVersionCImpl
      - BydBatteryBoxCommercialC130Impl
      - **BatteryFeneconHomeImpl**
      - **AbstractGoodWe, GoodWeGridMeterImpl**
      - AbstractEdge2Edge, Edge2EdgeEssImpl
      - IoWeidmuellerUr20Impl
      - **AbstractSocomecMeter**
    
    Co-authored-by: Stefan Feilmeier <[email protected]>
    Reviewed-by: Sebastian Asen <[email protected]>
    Co-authored-by: Michael Grill <[email protected]>
    Co-committed-by: Michael Grill <[email protected]>
    3 people committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    b62f2de View commit details
    Browse the repository at this point in the history
  14. Time-of-Use: split Optimizer and Controller

    - Introduce new Bundles for `Energy` and `Energy API`
    - Move Optimizer (i.e. all Jenetics related code) to `Energy`
    - New Channel `_sum/GridBuyPrice`
    - UI: show data in [kW] and cleanup code
    
    Reviewed-by: Michael Grill <[email protected]>
    sfeilmeier committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    8d29855 View commit details
    Browse the repository at this point in the history
  15. EnergyScheduler: fix behaviour without TimeOfUseTariff

    Before, the ComponentManager would report an error if there was no TimeOfUseTariff activated.
    sfeilmeier committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    ee3a743 View commit details
    Browse the repository at this point in the history
  16. RRD4j: correctly postprocess queried data

    - fix querying data with different resolution than 5 Minutes
    
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Michael Grill <[email protected]>
    Co-committed-by: Michael Grill <[email protected]>
    sfeilmeier and michaelgrill committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    2d22211 View commit details
    Browse the repository at this point in the history
  17. GoodWe 20 & 30: optionally show values per MPPT; not per String

    GoodWeChargerTwoStringImpl was used to represent one string from a GoodWe MPPT tracker that is responsible for two strings (GoodWe ET-Systems).
    
     Possible values given by GoodWe are:
     * MPPT Current
     * MPPT Power
     * String Current
     * String Voltage
    
    As the current values of one string are incorrect (so far DSP-Version 12, ARM-Version 27) the power cannot be calculated as expected.
    
    A new Component GoodWeChargerMpptTwoStringImpl is mirroring the GoodWe values to get the important values from
     * MPPT Current
     * MPPT Power
     * String Voltage (One of the two strings)
    
    Co-authored-by: Michael Grill <[email protected]>
    Reviewed-by: Michael Grill <[email protected]>
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Sebastian Asen <[email protected]>
    Co-committed-by: Sebastian Asen <[email protected]>
    3 people committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    e1fe1c2 View commit details
    Browse the repository at this point in the history
  18. UI/IBN Home 20 & 30: Modify chargers MPPT

    . Modified the IBN based on mockup given by Tobi (attached the file).
    . Added a unified MPPT instead of individual string fields.
    . Modified the pictures for selecting MPPT's
    
    Co-authored-by: Sebastian Asen <[email protected]>
    Co-authored-by: Michael Grill <[email protected]>
    Reviewed-by: Sebastian Asen <[email protected]>
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Sagar Venu <[email protected]>
    Co-committed-by: Sagar Venu <[email protected]>
    4 people committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    c6c409a View commit details
    Browse the repository at this point in the history
  19. UI: Revert adding detail navigation to production history

    - Revert adding detail navigation to production history caused by merging
    
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Lukas Rieger <[email protected]>
    Co-committed-by: Lukas Rieger <[email protected]>
    sfeilmeier and lukasrgr committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    1aa50e8 View commit details
    Browse the repository at this point in the history
  20. UI: add optional strict mode

    - Another step towards *strict mode* in UI
    - Add `typescript-strict-plugin` -> https://github.com/allegro/typescript-strict-plugin
    - Add `tsc` and `tsc-strict` to CI build
    - Add `// @ts-strict-ignore` comment in non-compliant code files
    
    Reviewed-by: Lukas Rieger <[email protected]>
    sfeilmeier committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    be69107 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    818534e View commit details
    Browse the repository at this point in the history
  22. UI: fix page count of pagination on search init

    - Fix Page count of edges pagination on initial search
    
    Reviewed-by: Michael Grill <[email protected]>
    Reviewed-by: Stefan Feilmeier <[email protected]>
    Co-authored-by: Lukas Rieger <[email protected]>
    Co-committed-by: Lukas Rieger <[email protected]>
    sfeilmeier and lukasrgr committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    f4a5264 View commit details
    Browse the repository at this point in the history
  23. Home: update BMS Registers ChargeMaxVoltage & DischargeMinVoltage

    - Set Home ChargeMaxVoltage & DischargeMinVoltage
    - Handle inverter specific behaviour on empty/full battery
    
    Co-authored-by: Sebastian Asen <[email protected]>
    Reviewed-by: Sebastian Asen <[email protected]>
    sfeilmeier and sebastianasen committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    654a301 View commit details
    Browse the repository at this point in the history
  24. Fix UI

    sfeilmeier committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    9bf6a42 View commit details
    Browse the repository at this point in the history
  25. Merge remote-tracking branch 'origin/develop' into feature/fems-backp…

    …orts
    
    # Conflicts:
    #	io.openems.edge.controller.ess.timeofusetariff/src/io/openems/edge/controller/ess/timeofusetariff/TimeOfUseTariffControllerImpl.java
    #	io.openems.edge.core/src/io/openems/edge/core/appmanager/dependency/aggregatetask/ComponentAggregateTaskImpl.java
    sfeilmeier committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    574aa8d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Fix UI build

    sfeilmeier committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    91ec87b View commit details
    Browse the repository at this point in the history
  2. Ignore ts-strict

    sfeilmeier committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    28a77df View commit details
    Browse the repository at this point in the history
  3. Update node to v20 LTS

    sfeilmeier committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    70336f8 View commit details
    Browse the repository at this point in the history