Update eslint rules and refactoring types. #2676
Conversation
miettal
commented
Jun 22, 2024
miettal
commented
- banned using Object, Function types
- refactor .eslintrc
1. eslint native rules 2. unused-imports 3. typescript-eslint 4. angular-eslint 5. stylistic
|
|
| "@stylistic/quote-props": [ | ||
| "warn", | ||
| "consistent" | ||
| ], |
There was a problem hiding this comment.
could you fix formatting, why did you change the order around?
There was a problem hiding this comment.
to clear rule cateogry. I commented on this commit.
4a1365c
| @@ -126,7 +126,7 @@ export class Service extends AbstractService { | |||
| // this.notify(notification); | |||
| } | |||
|
|
|||
| public setCurrentComponent(currentPageTitle: string | { languageKey: string, interpolateParams?: Object }, activatedRoute: ActivatedRoute): Promise<Edge> { | |||
| public setCurrentComponent(currentPageTitle: string | { languageKey: string, interpolateParams?: {} }, activatedRoute: ActivatedRoute): Promise<Edge> { | |||
There was a problem hiding this comment.
{} is better than Object but still not good, anyway this method is deprecated and shouldnt be used in the future anyway
| "{}": false, | ||
| "Object": false, | ||
| "Function": false | ||
| "{}": false |
There was a problem hiding this comment.
i would ban empty object as well, otherwise, type safety is not guaranteed
There was a problem hiding this comment.
Yes I want to ban {}. but in this repo there are using many {} type. especially {} used in json rpc related type. this means if I remove {} in this repo, this will be super heavy task(Many typing will needed....). so I focused to ban Object and Function.
There was a problem hiding this comment.
Reducing any type and banning {}, applying strictNullChecks is very very important...
if I have time, I will address this kind little by little in other PR.
There was a problem hiding this comment.
i understand in terms of being a heavy task, so i approve
