Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decrease using type of any to get typing benefit #2704

Merged

Conversation

miettal
Copy link
Contributor

@miettal miettal commented Jul 6, 2024

$ vi .eslintrc
drop        "@typescript-eslint/no-explicit-any": 0,
$ npx eslint src/
165 problems (165 errors, 0 warnings)
↓
121 problems (121 errors, 0 warnings)

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2704      +/-   ##
=============================================
+ Coverage      56.03%   56.05%   +0.02%     
- Complexity      8041     8047       +6     
=============================================
  Files           2059     2059              
  Lines          87513    87513              
  Branches        6418     6418              
=============================================
+ Hits           49032    49044      +12     
+ Misses         36797    36785      -12     
  Partials        1684     1684              

@sfeilmeier sfeilmeier requested a review from lukasrgr July 10, 2024 17:44
@sfeilmeier sfeilmeier removed the request for review from lukasrgr July 31, 2024 14:08
@sfeilmeier
Copy link
Contributor

Unfortunately this has merge conflicts with latest develop. I resolved them locally, but cannot push, because I don't have write permissions.

@miettal miettal force-pushed the bugfix/decrease-use-any-type branch 2 times, most recently from 1f0d169 to 8d2ccad Compare August 1, 2024 01:19
@miettal
Copy link
Contributor Author

miettal commented Aug 1, 2024

rebased!

@miettal miettal force-pushed the bugfix/decrease-use-any-type branch from 8d2ccad to 74a33a2 Compare August 1, 2024 01:47
@sfeilmeier sfeilmeier merged commit 552a570 into OpenEMS:develop Aug 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants