WIP : Long short term memory prediction models for Time series Data #2721
+10,030
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/LstmModel
Codecov ReportAttention: Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2721 +/- ##
=============================================
- Coverage 56.66% 55.93% -0.73%
- Complexity 8926 9146 +220
=============================================
Files 2167 2220 +53
Lines 91959 94176 +2217
Branches 6831 6974 +143
=============================================
+ Hits 52103 52671 +568
- Misses 37981 39600 +1619
- Partials 1875 1905 +30 |
|
Very interesting and nice pull request! Do you have benchmarks values? |
…into feature/LstmModel
sfeilmeier
requested changes
Sep 30, 2024
| * @return a {@link Prediction} object | ||
| */ | ||
| public static Prediction from(ValueRange valueRange, Interval interval, ZonedDateTime time, Integer... values) { | ||
| return from(valueRange, buildMapDuoDecimus(time, values)); |
There was a problem hiding this comment.
Interval is not checked here!
| * @return a {@link Prediction} object | ||
| */ | ||
| public static Prediction from(ValueRange valueRange, Interval interval, ZonedDateTime time, Integer... values) { | ||
| return from(valueRange, buildMapDuoDecimus(time, values)); |
There was a problem hiding this comment.
Need to discuss this "duodecimus" thing... it breaks a lot of assumptions (and Javadocs) if we suddenly have 5-minute predictions...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Model uses the LSTM (Type of Recurring neural network ) algorithm for predicting the Consumption and Production active power times series data.