Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix SimulatorApp bug related to creation of Ess.Power component #2722

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

parapluplu
Copy link
Contributor

The Ess.Power component is actually never deleted. An attempt to delete it, is ignored. I was not able to find out the reason for that. Since the component is created afterwards again, this change ensures, the component is updated with the desired enablePid property.

This change fixes only the issue mentioned in https://community.openems.io/t/a-singleton-component-for-pid-ess-power-is-already-existing/1897/10

There is also an issue related to setting the cycle time. The simulation does not start but just halts and does nothing as long as I do not uncomment the two lines which update the cycle time (and to speed up simulation set it manually to 0 before I actually start the simulation)

I'm still analyzing this problem and will create a follow up merge request for that.

The Ess.Power component is actually never deleted. An attempt to delete it, is ignored. I was not able to find out the reason for that.
Since the component is created afterwards again, this change ensures, the component is updated with the desired `enablePid` property.
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2722      +/-   ##
=============================================
- Coverage      56.05%   56.04%   -0.00%     
- Complexity      8044     8047       +3     
=============================================
  Files           2059     2059              
  Lines          87504    87513       +9     
  Branches        6417     6418       +1     
=============================================
  Hits           49041    49041              
- Misses         36778    36787       +9     
  Partials        1685     1685              

@sfeilmeier sfeilmeier merged commit 062d960 into OpenEMS:develop Jul 31, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants