fix: Fix SimulatorApp bug related to creation of Ess.Power component #2722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ess.Power component is actually never deleted. An attempt to delete it, is ignored. I was not able to find out the reason for that. Since the component is created afterwards again, this change ensures, the component is updated with the desired
enablePid
property.This change fixes only the issue mentioned in https://community.openems.io/t/a-singleton-component-for-pid-ess-power-is-already-existing/1897/10
There is also an issue related to setting the cycle time. The simulation does not start but just halts and does nothing as long as I do not uncomment the two lines which update the cycle time (and to speed up simulation set it manually to 0 before I actually start the simulation)
I'm still analyzing this problem and will create a follow up merge request for that.