Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend Metadata: reuse getPageDevice method for MetadataFile and MetadataDummy #2728

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

This fixes an issue where a bug had been fixed only in Dummy and not in File.
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

❗ There is a different number of reports uploaded between BASE (bb43bdf) and HEAD (d69261b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (bb43bdf) HEAD (d69261b)
2 1
Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #2728       +/-   ##
==============================================
- Coverage      56.01%   25.60%   -30.41%     
==============================================
  Files           2059      237     -1822     
  Lines          87511     5951    -81560     
  Branches        6420      885     -5535     
==============================================
- Hits           49013     1523    -47490     
+ Misses         36815     4354    -32461     
+ Partials        1683       74     -1609     

@sfeilmeier sfeilmeier merged commit 688f8ec into develop Aug 1, 2024
2 checks passed
@sfeilmeier sfeilmeier deleted the feature/fix-metadata-file branch August 1, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant