fix: fix system status modal. #2755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2755 +/- ##
=============================================
- Coverage 55.89% 55.88% -0.00%
+ Complexity 8047 8044 -3
=============================================
Files 2077 2077
Lines 87948 87948
Branches 6494 6494
=============================================
- Hits 49149 49144 -5
- Misses 37115 37121 +6
+ Partials 1684 1683 -1 |
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry past my commit has bug for making component list logic.
in this commit I use
concatbut it's not in-place method so this code doesn't work.This PR rewrte
concattopush.2664b13#diff-18c3e87449e26c6e1913ede0123a3d5aa61209b14e6cfb97fac0c9614553c352R591