FEMS-Backports 2024-08 (2) #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong variable used in consumption detail html Reviewed-by: Stefan Feilmeier <[email protected]> Co-authored-by: Lukas Rieger <[email protected]> Co-committed-by: Lukas Rieger <[email protected]>
- Introduction of [Routing Guards](https://v17.angular.io/api/router#types) - Not visible routes could be accessed through manually going there - Adding edge role check before accessing this route Reviewed-by: Sagar Venu <[email protected]>
Center refresh-content-spinner Reviewed-by: Sagar Venu <[email protected]>
- fix start for timeranges with not the first day of the month - fix readonly only worked with debugmode Reviewed-by: Hueseyin Sahutoglu <[email protected]> Co-authored-by: Michael Grill <[email protected]> Co-committed-by: Michael Grill <[email protected]>
Update Angular, Zone.js, Typescript Co-authored-by: Kai Jeschek <[email protected]> Reviewed-by: Sagar Venu <[email protected]>
- Enforce usage of double quotes - prohibit single quotes - backticks are still usable -> [ref](https://eslint.org/docs/latest/rules/quotes#double) Reviewed-by: Sagar Venu <[email protected]>
- Add eslint rule [`switch-exhaustiveness-check`](https://typescript-eslint.io/rules/switch-exhaustiveness-check/) Reviewed-by: Sagar Venu <[email protected]>
- Updating android api level due to googles new policy, enforcing `ANDROID_API_LEVEL=34` to be minimum version Reviewed-by: Kai Jeschek <[email protected]>
Add CI pipeline for building Android apps Co-authored-by: Lukas Rieger <[email protected]> Reviewed-by: Lukas Rieger <[email protected]>
Reviewed-by: Sebastian Asen <[email protected]> Co-authored-by: Johann Kaufmann <[email protected]> Co-committed-by: Johann Kaufmann <[email protected]>
If a history chart takes too long to load and the user switches the timerange, the old timerange will be shown instead of the actual one (at least for a few seconds, until the new chart is finished) Co-authored-by: Lukas Rieger <[email protected]> Reviewed-by: Lukas Rieger <[email protected]> Co-authored-by: Fabian Brandtner <[email protected]> Co-committed-by: Fabian Brandtner <[email protected]>
- Replace `setCurrentComponent` with `getCurrentEdge`, setCurrentComponent is already deprecated and shouldnt be used anymore Reviewed-by: Sagar Venu <[email protected]>
- Unify and refactor all FixDigitalOutputControllers and SingleThresholds in one widget in history - Refactoring them and using the new `CumulatedLevelActiveTime`-Channel Co-authored-by: Sebastian Asen <[email protected]> Reviewed-by: Sebastian Asen <[email protected]>
- Fix `TypeError: this.options.plugins is undefined` - To reproduce the error see "live" screen and open the modal for Time-of-Use with ADMIN role. Reviewed-by: Sagar Venu <[email protected]>
Codecov ReportAttention: Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2771 +/- ##
=============================================
+ Coverage 55.88% 55.91% +0.04%
- Complexity 8044 8052 +8
=============================================
Files 2077 2079 +2
Lines 87948 87949 +1
Branches 6494 6499 +5
=============================================
+ Hits 49142 49170 +28
+ Misses 37122 37088 -34
- Partials 1684 1691 +7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.