Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint to README to fix an error with building a Docker image #2833

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

j-eissler
Copy link
Contributor

This is just a small commit that should help people trying to build their own Docker image. When running the build command from the readme file the error failed to solve: error from sender: context canceled can occur. This can easily be fixed by making sure the Eclipse IDE isn't open. To avoid others having to search for a solution I would like to add this info to the readme.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2833      +/-   ##
=============================================
+ Coverage      55.91%   56.01%   +0.11%     
- Complexity      8052     8197     +145     
=============================================
  Files           2079     2103      +24     
  Lines          87955    89017    +1062     
  Branches        6502     6560      +58     
=============================================
+ Hits           49170    49853     +683     
- Misses         37094    37446     +352     
- Partials        1691     1718      +27     

@da-Kai
Copy link
Contributor

da-Kai commented Oct 8, 2024

@j-eissler
Thank you for your contribution! There are a few improvements I'd suggest to make it more comprehensive:

  1. It would be great to move this content to the end of the README under a new section titled # Common Problems and Solutions.

  2. The same topic should also be included in the backend Docker README, as it's relevant there too.
    tools/docker/backend/README.md

  3. The issue you're describing isn't exclusive to Eclipse IDE. It can occur with any program that locks files. Could you please adjust the wording to something like: "Ensure no program is accessing the files", and use Eclipse IDE as an example?

@j-eissler
Copy link
Contributor Author

@da-Kai Thanks for the feedback! I've updated the description according to your response.

@da-Kai da-Kai requested a review from sfeilmeier October 8, 2024 14:16
@sfeilmeier sfeilmeier merged commit 1b18fa0 into OpenEMS:develop Oct 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants