Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework clearBootLock using ECVF_BOOT_LOCKED vflag + $AB #566

Closed
KipK opened this issue Mar 10, 2023 · 1 comment
Closed

Rework clearBootLock using ECVF_BOOT_LOCKED vflag + $AB #566

KipK opened this issue Mar 10, 2023 · 1 comment

Comments

@KipK
Copy link
Collaborator

KipK commented Mar 10, 2023 •
edited
Loading

Refering to this ( lincomatic/open_evse#154 (comment) ) , we can catch the bootlock state using new ECVF_BOOT_LOCKED vflag. we should now check this after wifi module boot then call _openevse.clearBootLock if needed.

One should also clearBootLock() after receiving $AB command from evse.
edit: no the unlock should only be done after evsemanager has first set the current state.

https://github.com/OpenEVSE/ESP32_WiFi_V4.x/pull/548/files needs some rework to be this way
@KipK KipK mentioned this issue May 10, 2023
Merged
@KipK
Copy link
Collaborator Author

KipK commented May 11, 2023 •
edited
Loading

jeremypoulter/OpenEVSE_Lib#9 should close this with #618

@KipK KipK closed this as completed May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KipK