Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New settings / flags (#595) #618

Merged
merged 36 commits into from
May 21, 2023
Merged

New settings / flags (#595) #618

merged 36 commits into from
May 21, 2023

Conversation

KipK
Copy link
Collaborator

@KipK KipK commented May 2, 2023

FIxes #595
needs UI branch "newflags"

Not to be merged before UI migration

done:

  • wizard_passed ( fw + ui )
  • divert_type ( fw + ui )
  • vehicle_data_src ( fw + ui )
  • default_state (fw + ui )
  • set AP ssid & password ( fw + ui )
  • added /restart {"device": "gateway|evse"} to http api & mqtt + restartEvse() method in evseManager ( close Restarting controller via HTTP throws error 500 #479 ,

@KipK KipK force-pushed the newflags branch 2 times, most recently from 2c43911 to 04a7561 Compare May 2, 2023 15:10
@KipK
Copy link
Collaborator Author

KipK commented May 2, 2023

@jeremypoulter , I have segfault on divert_sim here. I have modified this (c3c68b7) in divert _sim. Any idea on what I've missed here ?

@KipK KipK marked this pull request as ready for review May 2, 2023 20:47
src/evse_monitor.cpp Outdated Show resolved Hide resolved
src/app_config.h Outdated Show resolved Hide resolved
src/divert.h Outdated Show resolved Hide resolved
src/evse_monitor.cpp Outdated Show resolved Hide resolved
@KipK
Copy link
Collaborator Author

KipK commented May 13, 2023

@jeremypoulter , when review is ok, don't merge it yet ( same for inputFilter too ). I'll have to merge the gui related branch to master first.

Can we decouple the daily builds from the gui commits now ?

@KipK
Copy link
Collaborator Author

KipK commented May 13, 2023

ah also can you bump a new openevse lib version ?

@jeremypoulter
Copy link
Collaborator

Can we decouple the daily builds from the gui commits now ?

Just need to remove the workflow in the GUI repo

@jeremypoulter
Copy link
Collaborator

ah also can you bump a new openevse lib version ?

Did a new release this morning

@KipK
Copy link
Collaborator Author

KipK commented May 13, 2023

Can we decouple the daily builds from the gui commits now ?

Just need to remove the workflow in the GUI repo

I've removed it and just put a gui build for testing.
This remind me to add some unit test on the gui later.

@jeremypoulter
Copy link
Collaborator

Yeah, testing would be excellent

@KipK
Copy link
Collaborator Author

KipK commented May 13, 2023

Yeah, testing would be excellent

Cool thing we can do with svelte is testing each components easily.
https://sveltesociety.dev/recipes/testing-and-debugging/unit-testing-svelte-component

src/main.cpp Outdated Show resolved Hide resolved
@KipK
Copy link
Collaborator Author

KipK commented May 15, 2023

@mathieucarbou , I have changed here the mqtt /restart to /restart {payload} , with payload = "gateway" or "evse"

@mathieucarbou
Copy link
Contributor

@mathieucarbou , I have changed here the mqtt /restart to /restart {payload} , with payload = "gateway" or "evse"

oh, nice :-)

@mathieucarbou
Copy link
Contributor

@mathieucarbou , I have changed here the mqtt /restart to /restart {payload} , with payload = "gateway" or "evse"

FYI I've grabbed the restart changed in a branch and I have updated my automation when Zoé vehicle is connected.

I will report back this week-end hopefully is the sun is helping.

src/divert.h Outdated Show resolved Hide resolved
src/web_server.cpp Outdated Show resolved Hide resolved
src/evse_man.h Show resolved Hide resolved
@KipK
Copy link
Collaborator Author

KipK commented May 19, 2023

@KipK : i actually updated my automation that was doing a sequence of FD FE for Zoé to use that considering the rapi support will be removed. What other solution otherwise?

Still continue use RAPI until 5.0 release ?
You are posting issues on dev branches we haven't even merged yet, and things we're still working on, hold-on a bit ;)

@jeremypoulter
Copy link
Collaborator

Changing the pause state to disable should resolve this issue. However this removes the ability for the charger to detect if a vehicle is connected when paused.

@mathieucarbou You are doing the same thing as enabling that option so the warning applies weither you enable that option or not, but lets keep this discussion in #512

@jeremypoulter
Copy link
Collaborator

jeremypoulter commented May 21, 2023

Need to also remove the replaced web files. IMHO I see little value in appending the file hash to the file name. The server should properly implement HTTP caching, so it should not be needed.

@KipK
Copy link
Collaborator Author

KipK commented May 21, 2023

Need to also remove the replaced web files. IMHO I see little value in appending the file hash to the file name. The server should properly implement HTTP caching, so it should not be needed.

I think it's part of Svelte/Vite cache invalidation handler. Not sure it has consequencies to disable it, haven't tested yet.

@jeremypoulter
Copy link
Collaborator

Fine to leave it on I guess, but do then need to make sure all the headers are deleted before bringing in a new UI version. Really need to write a GitHub workflow to do that...

@KipK
Copy link
Collaborator Author

KipK commented May 21, 2023

Really need to write a GitHub workflow to do that...

I have deleted the static files. Is there any need to have the generated statics of related UI commit ? Should stays empty like this on the git

@KipK KipK closed this May 21, 2023
@KipK KipK reopened this May 21, 2023
@jeremypoulter
Copy link
Collaborator

We commit the static files so you don't have to build the UI to build the firmware.

@KipK
Copy link
Collaborator Author

KipK commented May 21, 2023

We commit the static files so you don't have to build the UI to build the firmware.

ok, i'll update them here after the inputfilter merge.

@KipK KipK requested a review from jeremypoulter May 21, 2023 22:04
@KipK
Copy link
Collaborator Author

KipK commented May 21, 2023

UI changes merged in master, we're good on this one too.

@jeremypoulter
Copy link
Collaborator

Just the API doc errors to resolve

@jeremypoulter
Copy link
Collaborator

Oh ignore that, just noticed you added a change, let me check

@KipK
Copy link
Collaborator Author

KipK commented May 21, 2023

Oh ignore that, just noticed you added a change, let me check

yes should be ok, I've installed the vscode extension and spotted the errors

@jeremypoulter jeremypoulter merged commit beb2a21 into OpenEVSE:master May 21, 2023
@jeremypoulter jeremypoulter mentioned this pull request May 21, 2023
2 tasks
@KipK KipK deleted the newflags branch May 22, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add some new /config flags & /status property Restarting controller via HTTP throws error 500
4 participants