-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a GUI for configuring the vehicle data source #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…process is a lot more complex now and need to support MFA
- Made the property names snake case for consistency - Removed the tesla name spacing so other vehicles can be added in the future
…o be a bit more reliable
This is a bit more tolarent of changes in vehicles, ie adding or removing one and makes the GUI a bit simpler.
Hi, @jeremypoulter this looks great. I'm keen to test it. How can I resolve these conflicts? Will rebuilding the GUI solve them? |
Ah... Had not noticed those, will check but yeah probably just a GUI build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
Addin support for getting configuring the vehicle data source. Getting data from the Tesla API and MQTT are currently supported.
Displayed on the UI in the new vehicle tab as well as on the LCD.