OCPP: integration of further functions #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to newest version
matth-x
changed the title
|
Nice work! Could you provide some info with the PR to detail what changes are being made, e.g what functions are being added? |
|
Yes of course, sorry that I forgot it. This PR adds support for the following OCPP operations:
Changes:
|
|
FYI in #258 I added an API for resetting the ESP, should use that to reset |
|
Thank you Jeremy! Then I can integrate it next week right away. |
|
Should be ready now. Soft reset and FW update are integrated now as well. |
|
Did this PR also include the heartbeat fix?
…On Thu, Nov 4, 2021 at 1:27 PM Matthias Akstaller ***@***.***> wrote:
Should be ready now. Soft reset and FW update are integrated now as well.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#255 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN5QH27JHAI4PW67OAJ7ULUKK673ANCNFSM5GYASRSA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Yes, both the WebSocket and OCPP heartbeat work, I've checked them. Probably the issue was that my library was ignoring the OCPP heartbeat interval when it was set with the BootNotification. I have already solved that. But I am not 100% sure if that was the actual reason for the heartbeat problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.