Current Shaper now use "max_current" instead of "charge_current". #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARNING! If you were manually changing max_current before don't forget to switch to charge_current now
jeremypoulter
approved these changes
Dec 14, 2022
The text in the comment doesn't match the text in the title and (I think) the code. The change is to deprecate "charge_current" and use "max_current" instead, if I am not mistaken. Thanks. |
|
Nope it's for users that were using max_current before to throttle their charge_current over mqqt or api because shaper was using charge_current with higher priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING! If you were manually changing max_current using HTTP API or MQTT, don't forget to switch to charge_current now