Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some EnergyMeter fixes #583

Merged
merged 5 commits into from
Mar 31, 2023
Merged

some EnergyMeter fixes #583

merged 5 commits into from
Mar 31, 2023

Conversation

KipK
Copy link
Collaborator

@KipK KipK commented Mar 29, 2023

fix monthly counter wrong
session data initialised at reboot
fix time now using localtime for rotate()
publish energyMeter after counters reset

@KipK KipK changed the title fix monthly counter fix monthly counter wrong + session_elapsed initialised at reboot Mar 29, 2023
@KipK
Copy link
Collaborator Author

KipK commented Mar 30, 2023

I still have a problem with the en energyMeter rotate() with new time engine.

Could you help me to solve this ? Seems the time I get now is GMT and not local:

I don't know what to change here:

https://github.com/OpenEVSE/ESP32_WiFi_V4.x/blob/2d34a3a9bc817aa77b02f8868a97c976d73eed5d/src/energy_meter.cpp#L485

Weekly log was rotated 2 hours late here ( GMT +2 )

edit: should be fixed now.

@KipK KipK changed the title fix monthly counter wrong + session_elapsed initialised at reboot some EnergyMeter fixes Mar 30, 2023
@KipK
Copy link
Collaborator Author

KipK commented Mar 31, 2023

@jeremypoulter Can we merge this one and rebuild a prerelease ?

@jeremypoulter jeremypoulter merged commit edfc8d8 into OpenEVSE:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants