Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPP update and clean up #682

Merged
merged 14 commits into from
Sep 12, 2023
Merged

OCPP update and clean up #682

merged 14 commits into from
Sep 12, 2023

Conversation

matth-x
Copy link
Collaborator

@matth-x matth-x commented Jun 28, 2023

General update of the OCPP lib and a few changes:

@chris1howell chris1howell marked this pull request as ready for review August 17, 2023 19:15
chris1howell
chris1howell previously approved these changes Aug 17, 2023
@jeremypoulter
Copy link
Collaborator

@chris1howell I am not sure this was ready to be merged. Was still in draft and has references to dev libraries

@jeremypoulter
Copy link
Collaborator

Oh sorry looks like it is not draft any more, will check.

@matth-x
Copy link
Collaborator Author

matth-x commented Aug 17, 2023

Thanks for taking a look. I left it as a draft because I was hoping for more real world tests before merging. Anyway, I will publish the OCPP lib to the PIO registry ASAP so you can merge.

platformio.ini Outdated Show resolved Hide resolved
src/app_config.cpp Show resolved Hide resolved
src/ocpp.cpp Outdated Show resolved Hide resolved
@matth-x
Copy link
Collaborator Author

matth-x commented Aug 18, 2023

Now it should be ready to be merged

@matth-x
Copy link
Collaborator Author

matth-x commented Sep 5, 2023

@jeremypoulter Can you merge this? I tested it and it works as expected

@jeremypoulter
Copy link
Collaborator

Hi, I have been trying to get some time to review/test, made a start on it, but it is a big PR

@matth-x
Copy link
Collaborator Author

matth-x commented Sep 5, 2023

Okay, happy that it gets tested further. Do it when you find the time to, I'll keep the PR in sync.

@jeremypoulter jeremypoulter merged commit 9b32cef into OpenEVSE:master Sep 12, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants