Certificate management #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes sure valid certs and keys are added and use the certificate signature to generate the certificate ID.
Currently this is a little memory hungry (two copies of the certificate live in memory), but not expecting many certificates to be added this way.
If you configure the server certificate (and reboot) the server will use that certificate to bring the web server up in HTTPS mode. Currently seems to be a bit unstable, but this looks to be Mongoos/mbedTLS
…emypoulter/issue29
…ecting to AWS IoT
…emypoulter/issue29
…emypoulter/issue29
|
@jeremypoulter Will this PR help with #806? Are we ready to change status to Ready for review? |
|
Not necessarily, #806 just needs the compiled in certificate updating. IIRC this PR is largely ready, it was just the UI side of things that needed finishing off |
…emypoulter/issue29
This is mainly because JSON/JavaScript doesn't support 64bit numbers, but also is slightly more human readable
Just to allow quickly loading many certificates
…emypoulter/issue29
Not really needed and now too large with the latest certificate updates
To help verify if changes are being properly added
…emypoulter/issue29
chris1howell
previously approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to upload certificates to ESP32
Fixes #29
Fixes #30