Review: Datasets from EU-legislation

[han-f]

Issue description

I am submitting a set of metadata for review. The metadata is attached to a series of tables and already available on the OEP.
These are projections from European Member States submitted to the European Commission according to EU-legislation.

Workflow checklist

1. GitHub

• I have submitted this issue to have metadata and data review documented (Issue Feature/eu leg#89 #90)
• Create a new review-branch and push OEMetadata to new branch (feature/eu_leg#89). If this step is too difficult, attach a file with the metadata as a comment in this issue and let the reviewer know.

2. OEP

• Upload data to the OEP in schema model_draft (see upload tutorial)
• Link URL of data in this issue (model_draft.project_nameofdata)

3. Start a Review

• Start a pull request (PR) from review-branch to master
• Assign a reviewer and get in contact

4. Reviewer section

• A reviewer starts working on the issue
• Review data license
• A reviewer finished working on this issue (and awarded a badge)
• Update metadata on table
• Data moved to its final schema
• Add OEP tags to table
• Merge PR and delete review-branch
• Document final links of metadata and data in issue description
• Close issue

Metadata and data for review

Here are the links to my data and metadata:

• Data: https://openenergy-platform.org/dataedit/view/scenario?query=EU-legislation
• OEM v1.5.1: https://github.com/OpenEnergyPlatform/data-preprocessing/tree/review/eu_leg%2389/data-review/89-eu_leg

Reviewed and published metadata and data

Final naming and location of the data and metadata after the review are as follows:
schema.tablename

• 89-eu_leg

eio_ir_article23_t1 (2014-2020)

• scenario.eu_leg_data_2014_eio_ir_article23_t1
• scenario.eu_leg_data_2015_eio_ir_article23_t1
• scenario.eu_leg_data_2016_eio_ir_article23_t1
• scenario.eu_leg_data_2017_eio_ir_article23_t1
• scenario.eu_leg_data_2018_eio_ir_article23_t1
• scenario.eu_leg_data_2019_eio_ir_article23_t1
• scenario.eu_leg_data_2020_eio_ir_article23_t1

eio_ir_article23_t3 (2015-2020)

• scenario.eu_leg_data_2015_eio_ir_article23_t3
• scenario.eu_leg_data_2016_eio_ir_article23_t3
• scenario.eu_leg_data_2017_eio_ir_article23_t3
• scenario.eu_leg_data_2018_eio_ir_article23_t3
• scenario.eu_leg_data_2019_eio_ir_article23_t3
• scenario.eu_leg_data_2020_eio_ir_article23_t3

eaa (2016-2020)

• scenario.eu_leg_data_2016_eea
• scenario.eu_leg_data_2017_eea
• scenario.eu_leg_data_2018_eea
• scenario.eu_leg_data_2019_eea
• scenario.eu_leg_data_2020_eea

others

• scenario.eu_leg_data_2021_rep_table_3
• scneario.eu_leg_dim_parameter
• scenario.eu_leg_dim_category
• scenario.eu_leg_dim_gas
• scenario.eu_leg_dim_notation
• scenario.eu_leg_dim_scenario
• scenario.eu_leg_dim_unit

[han-f]

Data tables including metadata are here: https://openenergy-platform.org/dataedit/view/model_draft?query=EU-legislation
cc @wingechr - as info that review process has started.

[Ludee]

We added the metadata for testing the review process and documenting changes.

[steull]

@han-f, according to the licence, it is originally version 2.5 and your version is version 4.0. Are you aware that you are relicensing?

[han-f]

thanks for this - as we created a new database by harmonising terminology acorss all the submission years (they were different( and by introduced foreign key tables etc, does this not allow for a new license as this is very different to how the original data comes about?
Also the original data does not come as a table that holds all European Member States but as one table for each Member State for each submission.

Please note - the orginal licences also differ between data with source eionet (up to 2019 submissions) and source reportnet (starting 2021 submission)
cc @wingechr

[steull]

We realised that the metadata doesn't follow the latest v.1.5.0. We will add new files.
Furthermore, we realised, that the table names are difficult to understand (eio_ir_art...). We suggest to name the files: scenario.eea_eionet_eu_legislation_data_... Perhaps, it would be useful to include some parameter names for better understanding.

[han-f]

@wingechr what do you think?

[wingechr]

I think the somewhat cryptic table names are ok, otherwise they become too long. The human readable title exists for that very reason.

About the metadata: what is missing for v.1.5.0?

And thanks for checking

[Ludee]

The cryptic names are OK but we were not able to identify what it means. It would make sense to add additional info to the "description" or explain it here.
I suggest an alternative name that is closer to the OEP naming convention:
oekoinstitut_eea_eionet_eu_emissions_per_country_2020

I would also suggest to add some text about which data has been collected from the eionet website.
A comment of the method of collection would be good as well. Was it by hand or scripted?

[Ludee]

It seems like we had a misunderstanding.
The tables we just moved were not ready for review yet.
Please move them back to model_draft.

[Ludee]

@wingechr @han-f please update the first comment with all tables that should stay in scenario.

[wingechr]

it's easier for us if i move the tables back into model_draft (which I will do if no one objects). these are:

• parameter dimension table eu_leg_dim_parameter
• eionet parameter data tables eu_leg_data_****_eio_ir_article23_t3
• reportnet parameter table: eu_leg_data_2021_rep_table_3

[wingechr]

I moved the tables.

NOTE: for some reason, I got 500 Errors, although it seemed to have worked.

[wingechr]

moving tables from scenario to model_draft via API used to work.
now it still worked, but threw 500 server side errors and left table artefacts:

@MGlauer: could you at some point run the mirror task on the producion server? thx

@Ludee I have a hunch that the error is related to the fact that you moved the tables, but you were not the owner?

[Ludee]

I'm not sure if it is due to the permissions. I rather think it is some kind of bug when moving tables with existing metadata.
The tables are still in scenario and the suggested renaming has not been implemented. I'm not sure how to best rename existing tables. This can cause a lot of other problems.

[han-f]

I think the tables are back ins scenario, since @MGlauer had deleted the table artefacts and @wingechr had then moved the tables again.

I also think we can keep the table names as they are now and apply new names for tables that we subsequently add. Like this we won't produce further problems as these tables were now already shared with external people and I would be hesitant to do anything that could throw errors.

[Ludee]

OK, I totally agree with the renaming. Let's keep it like this.

I updated the comment above to included all related tables.
Please check if the list is complete.

[Ludee]

As discussed today @steull will update all metadata to v1.5.1, add it to the repo and included the review information (issue link and badge). Thanks to everybody for the constructive feedback!

[steull]

I have updated all tables on the OEP with the new version of the metadata

[Ludee]

Please add all metadata strings from the linked OEP tables to the repo. @steull
In addition revert the changes by reviewers in the metadata -> remove "Öko-Institut" from title.

[steull]

All metadata are available under the updated link in the description.
I also changed the title and removed "Öko-Institut".

[han-f]

I still see the "Öko-Institut" prefix at some tables it, even after refreshing:

https://openenergy-platform.org/dataedit/view/scenario?query=&tags=180&tags=326

cc @wingechr

[han-f]

That said - now all parameter table titles also refer to the Monitoring Mechanism Regulation (MMR), which is not the case for 2021 and also the description seems to have been copied over and is now not reflecting the data sources.

I will edit that back by hand now.

Good the review process will be made easier. Sometimes data owners use the functionality on the OEP to edit and add metadata, and then it may not be reflected in github.