Reg-test scripts modification to help avoid race condition and cleanup of caselist #1244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged
Feature or improvement description
As discussed in PR #1199, there is a frequent issue with race conditions when copying test case inputs over to the regression testing location. This is caused by the
shutil.copytree
command that errors out if there are pre-existing files. To get around this issue, thertl.copyTree
command is now used.Additionally, three test cases are dropped from the python interface testing and HydroDyn module testing. These cases are equivalent to ones that had been dropped from main OpenFAST test case list as they do not agree sufficiently between platforms for the new testing methodology (likely due to numerical issues in HydroDyn). These cases include:
5MW_ITIBarge_DLL_WTurb_WavesIrr_py
hd_5MW_ITIBarge_DLL_WTurb_WavesIrr
hd_5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth
Related issue, if one exists
See comment #1199 (comment) and following discussion in PR #1199 for context on the
rtl.copyTree
.The dropped cases should have been dropped with PR #1217.
Impacted areas of the software
This only affects the running of test cases.
Test results, if applicable
See above.