Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apache HttpClient to latest version #1080

Closed
mxmlnglt opened this issue Sep 23, 2019 · 4 comments
Closed

Update Apache HttpClient to latest version #1080

mxmlnglt opened this issue Sep 23, 2019 · 4 comments

Comments

@mxmlnglt
Copy link
Contributor

Hello,

I discovered that the version of Apache HttpClient used by (Open)Feign is only the 4.5.3 - see https://github.com/OpenFeign/feign/blob/master/httpclient/pom.xml - which is more than 2 years 1/2 old:

27 January 2017 - HttpComponents HttpClient 4.5.3 (GA) released
This is a maintenance release that fixes a number of issues discovered since release 4.5.2.

While the 4.5.10 (GA) has just been released: https://hc.apache.org/news.html

Could you please update? Thanks.

@velo
Copy link
Member

velo commented Sep 23, 2019

Hi Maxine,

Sure thing, send us a PR and I will review it asap

@mxmlnglt
Copy link
Contributor Author

Note: I'm currently trying to replace (old) API calls with OpenFeign (through Spring Cloud) on a project (already) using Apache HttpClient (in v4.5.9); thus I want to make sure I don't downgrade it.

@velo
Copy link
Member

velo commented Sep 23, 2019

Fwiw, you can overwrite the version of Apache http client by declaring the dependency on your project. Same is true for all feign dependencies

@velo
Copy link
Member

velo commented Oct 13, 2019

Feign 10.5.1 is released with this changed. Closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants