Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feign.jackson.jr.JacksonJrDecoder#findTransformer is not extendable #2297

Closed
yvasyliev opened this issue Jan 20, 2024 · 0 comments · Fixed by #2299
Closed

feign.jackson.jr.JacksonJrDecoder#findTransformer is not extendable #2297

yvasyliev opened this issue Jan 20, 2024 · 0 comments · Fixed by #2299

Comments

@yvasyliev
Copy link
Contributor

yvasyliev commented Jan 20, 2024 •
edited
Loading

Description

This is a follow up of #2296.

feign.jackson.jr.JacksonJrDecoder#findTransformer is private static which makes feign.jackson.jr.JacksonJrDecoder hard to extend.

Suggestion

To migrate feign.jackson.jr.JacksonJrDecoder#findTransformer from private static to protected, so JacksonJrDecoder will be more configurable.

Also, this implementation will make #2296 less severe.
yvasyliev added a commit to yvasyliev/feign that referenced this issue Jan 20, 2024
@yvasyliev
Allow override JacksonJrDecoder#findTransformer
580d7d2 
Fixes OpenFeign#2297
yvasyliev added a commit to yvasyliev/feign that referenced this issue Jan 20, 2024
@yvasyliev
Allow override JacksonJrDecoder#findTransformer
c3436da 
Fixes OpenFeign#2297
@yvasyliev yvasyliev mentioned this issue Jan 20, 2024
Merged
velo added a commit that referenced this issue Jan 20, 2024
@yvasyliev @velo
Allow override JacksonJrDecoder#findTransformer (#2299)
cd12fbc 
* Allow override JacksonJrDecoder#findTransformer
Fixes #2297

* Update JacksonJrDecoder.java

---------

Co-authored-by: Marvin <[email protected]>
velo added a commit that referenced this issue Oct 7, 2024
@yvasyliev @velo
Allow override JacksonJrDecoder#findTransformer (#2299)
79cc3fe 
* Allow override JacksonJrDecoder#findTransformer
Fixes #2297

* Update JacksonJrDecoder.java

---------

Co-authored-by: Marvin <[email protected]>
velo added a commit that referenced this issue Oct 8, 2024
@yvasyliev @velo
Allow override JacksonJrDecoder#findTransformer (#2299)
b07d995 
* Allow override JacksonJrDecoder#findTransformer
Fixes #2297

* Update JacksonJrDecoder.java

---------

Co-authored-by: Marvin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow override JacksonJrDecoder#findTransformer yvasyliev/feign
1 participant
@yvasyliev