Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxied and non-proxied Feign client on the same jvm #801

Closed
herrhilmi opened this issue Sep 29, 2018 · 1 comment · Fixed by #1045
Closed

Proxied and non-proxied Feign client on the same jvm #801

herrhilmi opened this issue Sep 29, 2018 · 1 comment · Fixed by #1045
Labels
enhancement For recommending new capabilities waiting for feedback Issues waiting for a response from either to the author or other maintainers

Comments

@herrhilmi
Copy link

herrhilmi commented Sep 29, 2018 •
edited
Loading

I'm using Feign & spring to build a core component, which is interacting with a variety of rest APIs. One of which is behind a proxy. So, the issue is that I can not setup the proxy using the system properties since it will be applied on JVM level and will affect other clients.

In order to resolve this, i've added this library "com.netflix.feign:feign-okhttp" to my project. Which resulted on a bad config and Spring's messages converters behaved wierdly. So, i guess the best solution's to provide another implementation of the Client interface that support proxy.
@herrhilmi herrhilmi mentioned this issue Sep 29, 2018
Closed
@kdavisk6 kdavisk6 added enhancement For recommending new capabilities waiting for votes Enhancements or changes proposed that need more support before consideration labels Oct 2, 2018
@kdavisk6
Copy link
Member

kdavisk6 commented Oct 2, 2018

Have you tried using the Apache Http Client instead? You can also create your own Client and Create the Feign Client Manually the client manually.

http://cloud.spring.io/spring-cloud-static/spring-cloud-openfeign/2.0.1.RELEASE/single/spring-cloud-openfeign.html#_creating_feign_clients_manually

This type of specialized use case is something that we typically would not add to the core library without more votes.

@kdavisk6 kdavisk6 added waiting for feedback Issues waiting for a response from either to the author or other maintainers and removed waiting for votes Enhancements or changes proposed that need more support before consideration labels May 28, 2019
kdavisk6 pushed a commit to kdavisk6/feign that referenced this issue Aug 23, 2019
@kdavisk6
OpenFeignGH-801: Adding support for JDK Proxy
5dbd8f7 
Adding a `Proxied` client implementation that extends the
`Default` client allowing for a JDK Proxy, along with
explict credential support.
kdavisk6 pushed a commit to kdavisk6/feign that referenced this issue Aug 23, 2019
@kdavisk6
OpenFeignGH-801: Adding support for JDK Proxy
07de483 
Fixes OpenFeign#801

Adding a `Proxied` client implementation that extends the `Default`
client allowing for a JDK Proxy, along with explict credential support.
@kdavisk6 kdavisk6 mentioned this issue Aug 23, 2019
Merged
kdavisk6 pushed a commit to kdavisk6/feign that referenced this issue Aug 23, 2019
@kdavisk6
OpenFeignGH-801: Adding support for JDK Proxy
823529f 
Fixes OpenFeign#801

Adding a `Proxied` client implementation that extends the `Default`
client allowing for a JDK Proxy, along with explict credential support.
kdavisk6 added a commit that referenced this issue Aug 26, 2019
@kdavisk6
GH-801: Adding support for JDK Proxy (#1045)
91e9882 
Fixes #801

Adding a `Proxied` client implementation that extends the `Default`
client allowing for a JDK Proxy, along with explict credential support.
velo pushed a commit that referenced this issue Oct 7, 2024
@kdavisk6
GH-801: Adding support for JDK Proxy (#1045)
4c0f7dc 
Fixes #801

Adding a `Proxied` client implementation that extends the `Default`
client allowing for a JDK Proxy, along with explict credential support.
velo pushed a commit that referenced this issue Oct 8, 2024
@kdavisk6
GH-801: Adding support for JDK Proxy (#1045)
6818807 
Fixes #801

Adding a `Proxied` client implementation that extends the `Default`
client allowing for a JDK Proxy, along with explict credential support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement For recommending new capabilities waiting for feedback Issues waiting for a response from either to the author or other maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-801: Adding support for JDK Proxy kdavisk6/feign
2 participants
@herrhilmi @kdavisk6