Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IllegalStateException on 1xx response codes #836

Closed
wirelessMousetail opened this issue Nov 9, 2018 · 2 comments · Fixed by #871
Closed

IllegalStateException on 1xx response codes #836

wirelessMousetail opened this issue Nov 9, 2018 · 2 comments · Fixed by #871
Labels
help wanted Issues we need help with tackling

Comments

@wirelessMousetail
Copy link

Looks like there is no support for 1xx responses - Illegal state exception is thrown by Feign on any response with code less than 200 during response building:
https://github.com/OpenFeign/feign/blob/master/core/src/main/java/feign/Response.java#L47

@rage-shadowman
Copy link
Contributor

I wonder why it checks at all. It doesn't check for >= 600 (which is where all the status lists I see stop).

@kdavisk6 kdavisk6 added question General usage or 'how-to' questions needs info Information is either missing or incomplete. labels Nov 19, 2018
@kdavisk6 kdavisk6 added the help wanted Issues we need help with tackling label Dec 5, 2018
@kdavisk6
Copy link
Member

kdavisk6 commented Dec 5, 2018

This seems like a fairly simple change. There are enough checks in the Client that the additional check when creating the response seems unnecessary. Since the body can be null, we should be able to support 1xx responses.

@kdavisk6 kdavisk6 removed needs info Information is either missing or incomplete. question General usage or 'how-to' questions labels Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues we need help with tackling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants