Allow 1xx status codes #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is unhappy due to formatting. Can you run Maven package locally? The build will fix any formatting for you. Once complete, please push a new commit. |
|
Sorry about that! It should hopefully be fixed now |
kdavisk6
approved these changes
Jan 8, 2019
|
@maly7 our typical process is for one of the maintainers to review, and if approved, we give the others a few days to weigh in. After that, if there are no additional comments, we'll merge your PR. Thanks for your help! |
kdavisk6
added
bug
kdavisk6
added
ready to merge
|
Thanks! Don't worry about the travis failures, there is an issue with the HTTP2 test case that is not related to your changes. |
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
* add support for 1xx status codes in Response * allow for any status code
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
* add support for 1xx status codes in Response * allow for any status code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Response didn't allow status codes in the 1xx series, only 200 and beyond were allowed. This fixes that by allowing status codes in the range from 100 <= status < 600.
Fixes #836