fix: Response.charset does not support RFC 7231 compliant Content-Type headers using quotation marks as application/json; charset="utf-8" #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanvitz
force-pushed
the
feature/fix-feign-response-charset
branch
3 times, most recently
from
24db9db
to
a56438c
Compare
…e headers using quotation marks as application/json; charset="utf-8"
stefanvitz
force-pushed
the
feature/fix-feign-response-charset
branch
from
a56438c
to
8faee8f
Compare
velo
reviewed
Jun 11, 2024
| @@ -314,7 +320,7 @@ public Reader asReader() { | |||
| } | |||
|
|
|||
| @Override | |||
| public Reader asReader(Charset charset) throws IOException { | |||
There was a problem hiding this comment.
Can we undo these throws IOException?
My concern is breaking existing feign users
There was a problem hiding this comment.
this is just on the implementation which is private final.
see above:
private static final class InputStreamBody implements Response.Body
so no feign user would be able to override this. and the exception is not thrown
velo
approved these changes
Jun 12, 2024
|
thx for the fast processing :) |
velo
added a commit
that referenced
this pull request
Oct 7, 2024
…e headers using quotation marks as application/json; charset="utf-8" (#2444) Co-authored-by: Stefan Vitz (C804185) <[email protected]> Co-authored-by: Marvin <[email protected]>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
…e headers using quotation marks as application/json; charset="utf-8" (#2444) Co-authored-by: Stefan Vitz (C804185) <[email protected]> Co-authored-by: Marvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
when migrating from rest template to feign i noticed that the feign Response object does not determine the charset in an RFC compliant way. As this charset() method is used e.g. by the JacksonDecoder class decoding an response with an RFC compliant Content-Type header like
application/json; charset="utf-8"will fail.See also:
https://datatracker.ietf.org/doc/html/rfc7231#section-3.1.1.1