Allow decoding of parameterizedTypes (generics) Fixes #759 #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
reviewed
Aug 8, 2018
| @@ -69,6 +70,10 @@ public Object decode(Response response, Type type) throws IOException { | |||
| return Util.emptyValueOf(type); | |||
| if (response.body() == null) | |||
| return null; | |||
| while (type instanceof ParameterizedType) { | |||
| ParameterizedType ptype = (ParameterizedType) type; | |||
There was a problem hiding this comment.
Would be nice to have a test covering this loop
There was a problem hiding this comment.
Sweet, thanks! I will review it right now
RicardoRdzG
force-pushed
the
JAXB-Generic-decoding
branch
from
3bd8d4b
to
3aec1a5
Compare
|
@velo Added a test and reformatted using eclipse formatter |
RicardoRdzG
changed the title
RicardoRdzG
force-pushed
the
JAXB-Generic-decoding
branch
from
3aec1a5
to
1a68eb7
Compare
velo
approved these changes
Aug 9, 2018
| .hasBody( | ||
| "<?xml version=\"1.0\" encoding=\"UTF-8\" " | ||
| + | ||
| "standalone=\"yes\"?><mockObject xsi:noNamespaceSchemaLocation=\"http://apihost/schema.xsd\" " |
There was a problem hiding this comment.
could you add the + sign in front of the string?
+ "standalone=\"yes\"?><mockObject xsi:noNamespaceSchemaLocation=\"http://apihost/schema.xsd\" "
+ "xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\">"
+ "<value>Test</value></mockObject>"
There was a problem hiding this comment.
I used the eclipse formatter on the file before uploading. Can that change be added to the formatting file?
RicardoRdzG
force-pushed
the
JAXB-Generic-decoding
branch
2 times, most recently
from
73a095b
to
444c298
Compare
|
@velo something is off with the Travis build for this PR. It succeeded for JDK8 but not for JDK11. Can you take a look? |
RicardoRdzG
force-pushed
the
JAXB-Generic-decoding
branch
from
444c298
to
968b4e9
Compare
|
build failure seems like a fluke, sent a small amend to kick the build |
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If type is a parameterizedType then extract rawType before proceeding with decoding instead of Trowing an exception