Add unit tests for class feign.Util #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersear
force-pushed
the
add-diffblue-tests
branch
from
19ffd3c
to
15c0ed9
Compare
| } | ||
|
|
||
| @Test | ||
| public void checkNotNullInputNullNotNullNullOutputNullPointerException() { |
There was a problem hiding this comment.
For future reference, these would make a lot more sense if there was more separation of terms. All of this "NullNotNullNull" stuff makes zero sense to new eyes on the project (kindoflikereadingasentencewithoutanyspacesinit - kinda like reading a sentence without spaces), but "checkNotNull_referenceNull_messageNotNull_messageArgsNull_nullPointerExceptionThrown" is a lot easier to read and understand the coder's intentions without looking at the code in the test (then when looking at the code, you can more easily tell if it really tests what was intended).
There was a problem hiding this comment.
@rage-shadowman thanks for your feedback. Much appreciated.
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've analysed your codebase and added some unit tests for the class feign.Util.
I've written the tests for these functions with the help of Diffblue Cover.
These tests should help detect regressions caused by future code changes.