Refactored Header and Query parameter JAXRS Contract Parsing #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of 10.x, the `headers()` and `queries()` collections on the `RequestTemplate` were made read only. The `JAXRSContract` was still attempting to manipulate those directly. THis was missed due to a use case not accounted for in the tests. I've added the appropriate use case and corrected the usage of the template.
kdavisk6
added
bug
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
As part of 10.x, the `headers()` and `queries()` collections on the `RequestTemplate` were made read only. The `JAXRSContract` was still attempting to manipulate those directly. THis was missed due to a use case not accounted for in the tests. I've added the appropriate use case and corrected the usage of the template.
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
As part of 10.x, the `headers()` and `queries()` collections on the `RequestTemplate` were made read only. The `JAXRSContract` was still attempting to manipulate those directly. THis was missed due to a use case not accounted for in the tests. I've added the appropriate use case and corrected the usage of the template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #890
As part of 10.x, the
headers()andqueries()collections on theRequestTemplatewere made read only. TheJAXRSContractwas stillattempting to manipulate those directly. This was missed due to a
use case not accounted for in the tests. I've added the appropriate
use case and corrected the usage of the template.