Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #921

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Update README.md #921

merged 1 commit into from
Mar 21, 2019

Conversation

Whitilied
Copy link
Contributor

@Whitilied Whitilied commented Mar 15, 2019 •
edited
Loading

method naming error

@kdavisk6
Copy link
Member

kdavisk6 commented Mar 17, 2019 •
edited
Loading

@Whitilied

Thank you for this PR. Before we can accept it, we need the following:

  • An issue created identifying what it is this PR is trying to address.
  • A Description on this PR explaining the change.

Once these updates have been done, we can look into this PR and provide feedback.

@kdavisk6 kdavisk6 added the needs info Information is either missing or incomplete. label Mar 17, 2019
@Whitilied Whitilied mentioned this pull request Mar 18, 2019
Closed
@Whitilied
Copy link
Contributor Author

ISSUE #923

@kdavisk6
Copy link
Member

@Whitilied

Thanks for the update.

@kdavisk6 kdavisk6 merged commit 10a4ead into OpenFeign:master Mar 21, 2019
@kdavisk6 kdavisk6 added this to the 10.2.1 milestone Apr 28, 2019
velo pushed a commit that referenced this pull request Oct 7, 2024
@Whitilied @kdavisk6
Update README.md (#921)
db1b794
velo pushed a commit that referenced this pull request Oct 8, 2024
@Whitilied @kdavisk6
Update README.md (#921)
d67cf81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdavisk6 kdavisk6 kdavisk6 approved these changes

Assignees
No one assigned
Labels
needs info Information is either missing or incomplete.
Projects
None yet
Milestone
10.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Whitilied @kdavisk6