Removed decoding from Body Template Expansion #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes OpenFeign#916 In certain cases, a Body Template will contain a JSON payload. To support this we are asking users to pct-encode the beginning and the end of the JSON object when providing it to the RequestLine so we don't reject it as an expression. Doing this requires that the we decode those markers before submitting the request. This change updates that logic to only decode the first and last characters only and not decode the entire payload, since Body values don't require any type of encoding.
velo
reviewed
Mar 28, 2019
kdavisk6
removed
ready to merge
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
Removed decoding from Body Template Expansion Fixes #916 In certain cases, a Body Template will contain a JSON payload. To support this we are asking users to pct-encode the beginning and the end of the JSON object when providing it to the RequestLine so we don't reject it as an expression. Doing this requires that the we decode those markers before submitting the request. This change updates that logic to only decode the first and last characters only and not decode the entire payload, since Body values don't require any type of encoding.
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Removed decoding from Body Template Expansion Fixes #916 In certain cases, a Body Template will contain a JSON payload. To support this we are asking users to pct-encode the beginning and the end of the JSON object when providing it to the RequestLine so we don't reject it as an expression. Doing this requires that the we decode those markers before submitting the request. This change updates that logic to only decode the first and last characters only and not decode the entire payload, since Body values don't require any type of encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #916
In certain cases, a Body Template will contain a JSON payload. To
support this we are asking users to pct-encode the beginning and the
end of the JSON object when providing it to the RequestLine so we don't
reject it as an expression. Doing this requires that the we decode those
markers before submitting the request.
This change updates that logic to only decode the first and last characters
only and not decode the entire payload, since Body values don't require
any type of encoding.