Parse Retry-After header responses that include decimal points #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfc7231 section 7.1.3 states that the Retry-After header can return delay-seconds value that is a non-negative decimal integer, representing time in seconds. Some servers return the second delay with a decimal point. Eg instead of 2 they return 2.0 This patch handles this case where the server has included a decimal point in their response.
velo
pushed a commit
to velo/feign
that referenced
this pull request
Jun 30, 2019
…eign#980) rfc7231 section 7.1.3 states that the Retry-After header can return delay-seconds value that is a non-negative decimal integer, representing time in seconds. Some servers return the second delay with a decimal point. Eg instead of 2 they return 2.0 This patch handles this case where the server has included a decimal point in their response.
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
rfc7231 section 7.1.3 states that the Retry-After header can return delay-seconds value that is a non-negative decimal integer, representing time in seconds. Some servers return the second delay with a decimal point. Eg instead of 2 they return 2.0 This patch handles this case where the server has included a decimal point in their response.
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
rfc7231 section 7.1.3 states that the Retry-After header can return delay-seconds value that is a non-negative decimal integer, representing time in seconds. Some servers return the second delay with a decimal point. Eg instead of 2 they return 2.0 This patch handles this case where the server has included a decimal point in their response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rfc7231 section 7.1.3 states that the Retry-After header can return a delay-seconds value
that is a non-negative decimal integer, representing time in seconds.
Some servers return the second delay with a decimal point. Eg instead of
2they return2.0This patch handles this case where the server has included a decimal point in their response.