Sort constructors in generated classes based on constructor toString method #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
approved these changes
Jan 26, 2024
|
What about master 6 branch create another PR or you will cherry pick to master branch? |
rimuln
added a commit
to rimuln/querydsl
that referenced
this pull request
Jan 31, 2024
…method (OpenFeign#272) sort constructors based on constructor toString method Co-authored-by: Lumír Návrat <[email protected]> (cherry picked from commit 487005f)
velo
added a commit
that referenced
this pull request
Feb 5, 2024
* Bump org.springframework.boot:spring-boot-starter-parent from 3.2.1 to 3.2.2 (#264) Bump org.springframework.boot:spring-boot-starter-parent Bumps [org.springframework.boot:spring-boot-starter-parent](https://github.com/spring-projects/spring-boot) from 3.2.1 to 3.2.2. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.2.1...v3.2.2) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-starter-parent dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Sort constructors in generated classes based on constructor toString method (#272) sort constructors based on constructor toString method Co-authored-by: Lumír Návrat <[email protected]> * Bump joda-time:joda-time from 2.12.6 to 2.12.7 (#288) Bumps [joda-time:joda-time](https://github.com/JodaOrg/joda-time) from 2.12.6 to 2.12.7. - [Release notes](https://github.com/JodaOrg/joda-time/releases) - [Changelog](https://github.com/JodaOrg/joda-time/blob/main/RELEASE-NOTES.txt) - [Commits](JodaOrg/joda-time@v2.12.6...v2.12.7) --- updated-dependencies: - dependency-name: joda-time:joda-time dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump git-code-format-maven-plugin.version from 5.1 to 5.3 (#287) Bumps `git-code-format-maven-plugin.version` from 5.1 to 5.3. Updates `com.cosium.code:google-java-format` from 5.1 to 5.3 - [Commits](Cosium/git-code-format-maven-plugin@5.1...5.3) Updates `com.cosium.code:git-code-format-maven-plugin` from 5.1 to 5.3 - [Commits](Cosium/git-code-format-maven-plugin@5.1...5.3) --- updated-dependencies: - dependency-name: com.cosium.code:google-java-format dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: com.cosium.code:git-code-format-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.junit:junit-bom from 5.10.1 to 5.10.2 (#286) Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.10.1 to 5.10.2. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.10.1...r5.10.2) --- updated-dependencies: - dependency-name: org.junit:junit-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lumír Návrat <[email protected]> Co-authored-by: Lumír Návrat <[email protected]>
velo
pushed a commit
that referenced
this pull request
Aug 29, 2024
…ers (#572) * Sort constructors in generated classes based on constructor toString method (#272) sort constructors based on constructor toString method Co-authored-by: Lumír Návrat <[email protected]> (cherry picked from commit 487005f) * Sort constructors in generated clases based on number of constructor parameters Signed-off-by: rimuln <[email protected]> * Sort constructors in generated clases based on number of constructor parameters - fix formatting Signed-off-by: rimuln <[email protected]> --------- Signed-off-by: rimuln <[email protected]> Co-authored-by: Lumír Návrat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class#getConstructors haven't defined order of array of constructors.
we run query-dsl-maven plugin that generates classes via GenericExporter and then we format them with Eclipse Formatter.
Between several executions JVM returns some constructor in different order.
This is attempt to make it somehow sorted.