Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sing file installer #667

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Dec 19, 2023

Developers certificate of origin

@mikemhenry mikemhenry marked this pull request as ready for review December 19, 2023 16:14
@mikemhenry
Copy link
Contributor Author

@IAlibay this fixes it, I think I made changes to the single file installer without testing them, since I know the syntax of mamba-org/setup-micromamba@v1 hasn't changed but I may have changed it from the old one after our last release

@mikemhenry mikemhenry enabled auto-merge (squash) December 19, 2023 16:15
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a3b5305) 92.82% compared to head (195bdf3) 90.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
- Coverage   92.82%   90.99%   -1.83%     
==========================================
  Files         128      128              
  Lines        8711     8711              
==========================================
- Hits         8086     7927     -159     
- Misses        625      784     +159     
Flag Coverage Δ
fast-tests 90.99% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry mikemhenry merged commit 2213b71 into main Dec 19, 2023
10 of 11 checks passed
@mikemhenry mikemhenry deleted the fix/single_file_installer_remove_cache branch December 19, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants