Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PyMBAR solver to "robust" and use PyMBAR4 #871

Closed
wants to merge 7 commits into from
Closed

Conversation

hannahbaumann
Copy link
Contributor

@hannahbaumann hannahbaumann commented Jun 17, 2024

Checklist

  • Added a news entry

Developers certificate of origin

@pep8speaks
Copy link

pep8speaks commented Jun 17, 2024

Hello @hannahbaumann! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-07-04 12:15:00 UTC

@hannahbaumann hannahbaumann changed the title Set solver to robust Set PyMBAR solver to robust and use PyMBAR4 Jun 17, 2024
@hannahbaumann hannahbaumann linked an issue Jun 17, 2024 that may be closed by this pull request
@hannahbaumann hannahbaumann changed the title Set PyMBAR solver to robust and use PyMBAR4 Set PyMBAR solver to "robust" and use PyMBAR4 Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (ecc8a50) to head (30b32e2).
Report is 100 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
- Coverage   93.98%   91.36%   -2.62%     
==========================================
  Files         134      134              
  Lines        9790     9790              
==========================================
- Hits         9201     8945     -256     
- Misses        589      845     +256     
Flag Coverage Δ
fast-tests 91.36% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry
Copy link
Contributor

IMHO this should get a news entry since this change could cause a system to go from working to not working.

@IAlibay
Copy link
Member

IAlibay commented Jun 19, 2024

IMHO this should get a news entry since this change could cause a system to go from working to not working.

Agreed - this is more of a proof of concept at the moment, @RiesBen is taking over testing for this. We'll need to do a few PLB systems to convince ourselves that this works.

@jameseastwood
Copy link
Contributor

This should not be merged, because the fix is happening in openmmtools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with PyMBAR4
5 participants