move slow import inside function call #955
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cli commands, slow imports should be moved inside functions (as recommended here).
By moving the
plan_alchemical_network_output
import from the top of the file to inside the functions for rbfe and rhfe network planning, we avoid importingopenfe
during the command-gathering process.The
--help
and--version
calls now take 0.15 seconds instead of ~4 seconds.Ideally, we will also speed up
import openfe
, which was the root cause of this slow behavior, in another PR.Checklist
news
entryDevelopers certificate of origin