Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rubocop #114

Merged
merged 4 commits into from
Feb 17, 2022
Merged

Add rubocop #114

merged 4 commits into from
Feb 17, 2022

Conversation

eliotjordan
Copy link
Contributor

  • Add rubocop and rubocop config file
  • Fix cops and add rubocop-todo
  • Add rubocop-rake

Closes #113

@eliotjordan eliotjordan marked this pull request as draft February 17, 2022 18:46
@eliotjordan eliotjordan marked this pull request as ready for review February 17, 2022 18:48
@dl-maura
Copy link
Collaborator

ran locally and it worked

@dl-maura dl-maura merged commit b0053ae into main Feb 17, 2022
@eliotjordan eliotjordan deleted the 113-rubocop branch February 17, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpendragon tpendragon tpendragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rubocop
3 participants
@eliotjordan @dl-maura @tpendragon