Avoid nesting cloned OGM repos inside themselves #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatbudakguy
force-pushed
the
prevent-nested-clones
branch
from
60bae0d
to
6470322
Compare
Providing both `directory` and `path` to Git.clone results in the repo being cloned into a directory nested inside itself. This may be a fix for #144.
thatbudakguy
force-pushed
the
prevent-nested-clones
branch
from
6470322
to
ef9dda2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing both
directoryandpathto Git.clone results inthe repo being cloned into a directory nested inside itself.
We don't need to provide
directory(using the default of the repo's name is fine), and we actually wantpathto be the OpenGeoMetadata root (defaulttmp/opengeometadata) instead of the repo's name.This may be a fix for #144.