Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds in basic geoblacklight schema validation and geoblacklight enhancment metadata #19

Merged
merged 4 commits into from
Apr 8, 2015

Conversation

mejackreed
Copy link
Member

This pull request significantly improves support for GeoBlacklight-Schema. GeoBlacklight-Schema has moved away from being xml based to JSON based and this pull request modifies GeoCombine with this change in mind by doing the following.

  • it creates a way to validate geoblacklight-schema json using the schema validation from https://github.com/geoblacklight/geoblacklight-schema/blob/master/geoblacklight-schema.json
  • it modifies iso2geoBL.xsl to output json that is almost compliant geoblacklight-schema
  • provides a way to create GeoCombine::Geoblacklight objects that do the following:
    • can be created with a valid JSON string of geoblacklight-schema
    • output valid json using #to_json
    • can take a fields argument as a Hash that merges with the original metadata
    • provides an #enhance_metadata method that does some enhancements, and translations on geoblacklight-schema metadata

@mejackreed mejackreed changed the title adds in basic geoblacklight schema validation adds in basic geoblacklight schema validation and geoblacklight enhancment metadata Apr 2, 2015
@mejackreed
Copy link
Member Author

Just wanted to cc other folks here for comment: @waynegraham @drh-stanford @eliotjordan @gravesm @kimdurante

@coveralls
Copy link

Coverage Status

Coverage increased (+0.33%) to 97.89% when pulling a27ac41 on schema-validation into fdcf772 on master.

@mejackreed
Copy link
Member Author

Also the enhance_metadata method should close #14

@coveralls
Copy link

Coverage Status

Coverage increased (+0.33%) to 97.89% when pulling 7efc842 on schema-validation into fdcf772 on master.

mejackreed added a commit that referenced this pull request Apr 8, 2015
adds in basic geoblacklight schema validation and geoblacklight enhancment metadata
@mejackreed mejackreed merged commit bdd0aaa into master Apr 8, 2015
@mejackreed mejackreed deleted the schema-validation branch April 8, 2015 16:23
@eliotjordan
Copy link
Contributor

Apologies for the late reply. Just got back from 🍹 😎. This looks good. From geoblacklight/geoblacklight-schema#51 I see that idea is to move our geoblacklight.xml docs to geoblacklight.json docs. Is there a plan to remove xml support entirely at some point?

@mejackreed
Copy link
Member Author

No worries @eliotjordan ... hope you had a good time. I think people will still be able to index xml docs, but the canonical format for geoblacklight-schema will be json. Validation in GeoCombine will happen using json schema validation.

@mejackreed mejackreed modified the milestone: v0.0.6 Apr 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants