Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tlg0732.tlg010 #1891

Merged
merged 2 commits into from
Nov 3, 2017
Merged

Added tlg0732.tlg010 #1891

merged 2 commits into from
Nov 3, 2017

Conversation

planatheisa
Copy link
Contributor

Checking hook.

@ghost
Copy link

ghost commented Oct 26, 2017

Global

Changed Status
metadata_passing +1
metadata_total +1
nodes_count +1
texts_passing +1
texts_total +1

Words

Changed Status
grc +30915

Units

Changed Status
./data/tlg0732/tlg010/__cts__.xml New
./data/tlg0732/tlg010/tlg0732.tlg010.1st1K-grc1.xml New
./data/tlg0732/tlg010/__cts__.xml Passing
./data/tlg0732/tlg010/tlg0732.tlg010.1st1K-grc1.xml Passing

Hook UI build recap

Copy link
Contributor

@sonofmun sonofmun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The biggest thing to change is to add more citation units that are smaller than the whole work.

<teiHeader xml:lang="eng">
<fileDesc>
<titleStmt>
<title>De anima</title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need xml:lang="lat" attribute on title.

<title>De anima</title>
<author>Alexander of Aphrodisias</author>
<editor>Ivo Bruns</editor>
<sponsor>HARVARD COLLEGE LIBRARY</sponsor>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to title case instead of all upper case.

</availability>
<date>2017</date>
<publisher>Harvard College Library</publisher>
<pubPlace>United State</pubPlace>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "United States".

<pb n="1"/>
<head>ΑΛΕΞΑΝΔΡΟΥ ΑΦΡΟΔΙΣΙΕΩΣ ΠΕΡΙ ΨΥΧΗΣ.</head>
<note type="marginal">f. 123r Aid.</note>
<p>Ἡ μὲν πρόθεσις ἡμῖν, περὶ ψυχῆς εἰπεῖν τῆς <add cause="fix">τοῦ</add> ἐν
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The work as a whole is too long to have as a single citation unit. I would either add @n attributes to the <p> elements or enclose them all in <div> elements to break the work up and make it more readable online.

<listBibl>
<biblStruct>
<monogr>
<title>Supplementum Aristotelicum</title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need xml:lang="lat" attribute here.

@ghost
Copy link

ghost commented Nov 2, 2017

Global

Changed Status
metadata_passing +1
metadata_total +1
nodes_count +32
texts_passing +1
texts_total +1

Words

Changed Status
grc +30915

Units

Changed Status
./data/tlg0732/tlg010/__cts__.xml New
./data/tlg0732/tlg010/tlg0732.tlg010.1st1K-grc1.xml New
./data/tlg0732/tlg010/__cts__.xml Passing
./data/tlg0732/tlg010/tlg0732.tlg010.1st1K-grc1.xml Passing

Hook UI build recap

@sonofmun sonofmun merged commit b993697 into master Nov 3, 2017
@sonofmun sonofmun deleted the tlg0732.tlg010 branch November 3, 2017 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants